[PATCH i-g-t 7/7] tests/xe_intel_bb: Dump do png without detiling

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Wed Feb 28 21:26:20 UTC 2024


On Wed, Feb 28, 2024 at 05:22:46PM +0000, Matthew Auld wrote:
> On 28/02/2024 14:54, Zbigniew Kempczyński wrote:
> > On my work on Lunarlake I often needed to inspect surface without
> > detiling. Replace dumping surface exactly how it looks in the memory.
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Matthew Auld <matthew.auld at intel.com>
> 
> Not sure how to parse "Dump do png" ?

Eh, should be 'Dump to png'. Thanks for spotting this and for the
review of the series. As I see full run is still ongoing I'm going to
to wait until it will complete.

--
Zbigniew
> 
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
> 
> > ---
> >   tests/intel/xe_intel_bb.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c
> > index ef12715dea..c3a4b5450e 100644
> > --- a/tests/intel/xe_intel_bb.c
> > +++ b/tests/intel/xe_intel_bb.c
> > @@ -913,9 +913,9 @@ static int render(struct buf_ops *bops, uint32_t tiling,
> >   	if (write_png) {
> >   		snprintf(name, sizeof(name) - 1,
> >   			 "render_dst_tiling_%d.png", tiling);
> > -		intel_buf_write_to_png(&src, "render_src_tiling_none.png");
> > -		intel_buf_write_to_png(&dst, name);
> > -		intel_buf_write_to_png(&final, "render_final_tiling_none.png");
> > +		intel_buf_raw_write_to_png(&src, "render_src_tiling_none.png");
> > +		intel_buf_raw_write_to_png(&dst, name);
> > +		intel_buf_raw_write_to_png(&final, "render_final_tiling_none.png");
> >   	}
> >   	/* We'll fail on src <-> final compare so just warn */


More information about the igt-dev mailing list