[PATCH i-g-t 1/5] Documentation refactoring part 1

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Feb 29 15:25:19 UTC 2024


Hi Katarzyna,
On 2024-02-29 at 11:19:05 +0000, Katarzyna Piecielska wrote:
> Unify documentation for Intel i915 tests that we have by  moving
> common parts to be available for all tests.

Some of the tests are core/generic ones, like core_hotunplug.c

I would like to also see some prefix in subject, like:

[PATCH i-g-t 1/5] tests: Documentation refactoring part 1

> 
> This is part 1 to make review easier.
- ^^^^^^^^^^^^^^
This belongs to cover letter, not here. With that fixed:

Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Mauro Carvalho Chehab <mchehab at kernel.org>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/core_hotunplug.c       |  57 +++++--------
>  tests/device_reset.c         |  17 ++--
>  tests/dmabuf.c               |  13 ++-
>  tests/drm_mm.c               |  84 +------------------
>  tests/intel/api_intel_bb.c   | 152 ++---------------------------------
>  tests/intel/debugfs_test.c   |  32 +++-----
>  tests/intel/gem_basic.c      |  22 ++---
>  tests/intel/gem_blits.c      |   2 +-
>  tests/intel/gem_ccs.c        |   9 +--
>  tests/intel/gem_close_race.c |  39 +++------
>  tests/intel/gem_create.c     |  87 ++++++--------------
>  11 files changed, 94 insertions(+), 420 deletions(-)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index be80d479f..f578afa4a 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -44,64 +44,43 @@
>   * Description: Examine behavior of a driver on device hot unplug
>   * Feature: SMI, core
>   * Test category: functionality test
> - *
> - * SUBTEST: hotrebind
>   * Category: Software building block
>   * Sub-category: driver
>   * Functionality: device hotplug
> - * Description:
> - *   Check if the driver can be cleanly rebound to a device with a still open hot unbound driver
> - *   instance
>   * Run type: FULL
>   *
> + * SUBTEST: hotrebind
> + * Description: Check if the driver can be cleanly rebound to a device with a
> + *		still open hot unbound driver instance
> + *
>   * SUBTEST: hotrebind-lateclose
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if a hot unbound driver instance still open after hot rebind can be cleanly released
> - * Run type: FULL
> + * Description: Check if a hot unbound driver instance still open after hot
> + *		rebind can be cleanly released
>   *
>   * SUBTEST: hotreplug
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if a hot unplugged and still open device can be cleanly restored
> - * Run type: FULL
> + * Description: Check if a hot unplugged and still open device can be cleanly
> + *		restored
>   *
>   * SUBTEST: hotreplug-lateclose
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if an instance of a still open while hot replugged device can be cleanly released
> - * Run type: FULL
> + * Description: Check if an instance of a still open while hot replugged device
> + *		can be cleanly released
>   *
>   * SUBTEST: hotunbind-rebind
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if the driver can be cleanly unbound from an open device, then released and rebound
> - * Run type: FULL
> + * Description: Check if the driver can be cleanly unbound from an open device,
> + *		then released and rebound
>   *
>   * SUBTEST: hotunplug-rescan
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if an open device can be cleanly unplugged, then released and restored
> - * Run type: FULL
> + * Description: Check if an open device can be cleanly unplugged, then released
> + *		and restored
>   *
>   * SUBTEST: unbind-rebind
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if the driver can be cleanly unbound from a device believed to be closed, then rebound
> + * Description: Check if the driver can be cleanly unbound from a device
> + *		believed to be closed, then rebound
>   * Run type: BAT
>   *
>   * SUBTEST: unplug-rescan
> - * Category: Software building block
> - * Sub-category: driver
> - * Functionality: device hotplug
> - * Description: Check if a device believed to be closed can be cleanly unplugged, then restored
> - * Run type: FULL
> + * Description: Check if a device believed to be closed can be cleanly
> + *		unplugged, then restored
>   */
>  
>  IGT_TEST_DESCRIPTION("Examine behavior of a driver on device hot unplug");
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index ef08164aa..e1e3ac78d 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -17,29 +17,26 @@
>  /**
>   * TEST: device reset
>   * Description: Examine behavior of a driver on device sysfs reset
> + * Category: Server
> + * Feature: reset
> + * Functionality: reset
> + * Sub-category: Reset
> + * Test category: GEM_Legacy
>   * Run type: FULL
>   *
>   * SUBTEST: cold-reset-bound
>   * Description: Cold Resets device with bound driver
> - * Feature: reset
>   *
>   * SUBTEST: reset-bound
>   * Description: Resets device with bound driver
> - * Feature: reset
>   *
>   * SUBTEST: unbind-cold-reset-rebind
>   * Description: Unbinds driver from device, initiates cold reset then rebinds driver to device
> - * Feature: reset
>   *
>   * SUBTEST: unbind-reset-rebind
> - * Category: Server
> - * Description:
> - *   Unbinds driver from device, initiates reset then rebinds driver to device
> - *   validating device resets
> + * Description: Unbinds driver from device, initiates reset then rebinds driver
> + *		to device validating device resets
>   * Feature: reset, sriov-reset
> - * Functionality: reset
> - * Sub-category: sysman
> - * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
> diff --git a/tests/dmabuf.c b/tests/dmabuf.c
> index 2ac105423..977b04043 100644
> --- a/tests/dmabuf.c
> +++ b/tests/dmabuf.c
> @@ -27,21 +27,18 @@
>   * TEST: dmabuf
>   * Description: Kernel selftests for the dmabuf API
>   * Feature: mapping, prime
> + * Category: Infrastructure
> + * Description: drm_mm range manager SW validation
> + * Functionality: DRM
> + * Sub-category: Memory management
> + * Test category: GEM_Legacy
>   * Run type: BAT
>   *
>   * SUBTEST: all-tests
>   *
>   * SUBTEST: all-tests at dma_fence
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: all-tests at sanitycheck
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Kernel selftests for the dmabuf API");
> diff --git a/tests/drm_mm.c b/tests/drm_mm.c
> index e6ba22474..f2e6c6cd1 100644
> --- a/tests/drm_mm.c
> +++ b/tests/drm_mm.c
> @@ -27,129 +27,53 @@
>   * TEST: drm mm
>   * Description: Basic sanity check of DRM's range manager (struct drm_mm)
>   * Feature: mapping
> + * Category: Infrastructure
> + * Functionality: DRM memory mangemnt
> + * Sub-category: Memory management
> + * Test category: GEM_Legacy
>   * Run type: FULL
>   *
>   * SUBTEST: drm_mm
>   *
>   * SUBTEST: drm_mm at align
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at align32
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at align64
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at bottomup
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at color
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at color_evict
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at color_evict_range
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at debug
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at evict
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at evict_range
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at frag
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at highest
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at init
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at insert
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at insert_range
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at lowest
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at replace
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at reserve
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at sanitycheck
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: drm_mm at topdown
> - * Category: Infrastructure
> - * Description: drm_mm range manager SW validation
> - * Functionality: DRM memory mangemnt
> - * Test category: GEM_Legacy
>   */
>  
>  IGT_TEST_DESCRIPTION("Basic sanity check of DRM's range manager (struct drm_mm)");
> diff --git a/tests/intel/api_intel_bb.c b/tests/intel/api_intel_bb.c
> index 59ed244f0..24f96fcf5 100644
> --- a/tests/intel/api_intel_bb.c
> +++ b/tests/intel/api_intel_bb.c
> @@ -43,210 +43,72 @@
>  #include "intel_blt.h"
>  /**
>   * TEST: api intel bb
> - * Description: intel_bb API check.
> - * Run type: FULL
> - *
> - * SUBTEST: add-remove-objects
>   * Category: Infrastructure
>   * Description: checking dummy buffer creation & submission
>   * Feature: igt_core
>   * Functionality: dummy buffer creation & submission
>   * Sub-category: IGT Lib
>   * Test category: GEM_Legacy
> + * Run type: FULL
> + *
> + * SUBTEST: add-remove-objects
>   *
>   * SUBTEST: bb-with-allocator
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: blit-noreloc-keep-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: blit-noreloc-purge-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: blit-reloc-keep-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: blit-reloc-purge-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: crc32
>   * Description: Compare cpu and gpu crc32 sums on input object
> - * Feature: igt_core
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: delta-check
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: destroy-bb
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: full-batch
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: intel-bb-blit-none
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: intel-bb-blit-x
> - * Feature: igt_core
>   *
>   * SUBTEST: intel-bb-blit-y
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: lot-of-buffers
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: misplaced-blitter
> - * Category: Infrastructure
> - * Description:
> - *   Execute intel_bb with set of engines provided by userspace
> - *   checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
> + * Description: Execute intel_bb with set of engines provided by userspace
> + *		checking dummy buffer creation & submission
>   *
>   * SUBTEST: object-noreloc-keep-cache-simple
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: object-noreloc-purge-cache-simple
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: object-reloc-keep-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: object-reloc-purge-cache
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: offset-control
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: purge-bb
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: render
> - * Feature: igt_core
>   *
>   * SUBTEST: render-ccs
> - * Feature: igt_core
>   *
>   * SUBTEST: reset-bb
> - * Category: Infrastructure
> - * Description:
> - *   Ensure reset is possible on fresh bb
> - *   checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
> + * Description: Ensure reset is possible on fresh bb checking dummy buffer
> + *		creation & submission
>   *
>   * SUBTEST: reset-flags
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: simple-bb
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: simple-bb-ctx
> - * Category: Infrastructure
> - * Description: checking dummy buffer creation & submission
> - * Feature: igt_core
> - * Functionality: dummy buffer creation & submission
> - * Sub-category: IGT Lib
> - * Test category: GEM_Legacy
>   */
>  
>  #define PAGE_SIZE 4096
> diff --git a/tests/intel/debugfs_test.c b/tests/intel/debugfs_test.c
> index b67bfabac..9706b81e1 100644
> --- a/tests/intel/debugfs_test.c
> +++ b/tests/intel/debugfs_test.c
> @@ -33,43 +33,29 @@
>   * TEST: debugfs test
>   * Description: Read entries from debugfs, hwmon and sysfs paths.
>   * Feature: core
> + * Category: Infrastructure
> + * Functionality: debugfs
> + * Sub-category: uapi
> + * Test category: uapi
> + * Run type: FULL
>   *
>   * SUBTEST: basic-hwmon
> - * Category: Infrastructure
> - * Description:
> - *   Read all entries from hwmon path
> - *   validating debugfs entries
> - * Functionality: debugfs entries
> + * Description: Read all entries from hwmon path validating debugfs entries
>   * Run type: BAT
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: read_all_entries
> - * Category: Infrastructure
> - * Description:
> - *   Read all entries from debugfs path.
> - *   validating debugfs entries
> - * Functionality: debugfs entries
> + * Description: Read all entries from debugfs path validating debugfs entries
>   * Run type: BAT
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: read_all_entries_display_off
>   * Description: Read all debugfs entries with display on/off.
> - * Run type: FULL
>   *
>   * SUBTEST: read_all_entries_display_on
>   * Description: Read all debugfs entries with display on/off.
> - * Run type: FULL
>   *
>   * SUBTEST: sysfs
> - * Category: Infrastructure
> - * Description:
> - *   Read all entries from sysfs path.
> - *   validating debugfs entries
> - * Functionality: debugfs entries
> - * Run type: FULL
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Read all entries from sysfs path validating debugfs entries
> + *
>   */
>  
>  IGT_TEST_DESCRIPTION("Read entries from debugfs, hwmon and sysfs paths.");
> diff --git a/tests/intel/gem_basic.c b/tests/intel/gem_basic.c
> index 3485f92c8..513113cd1 100644
> --- a/tests/intel/gem_basic.c
> +++ b/tests/intel/gem_basic.c
> @@ -44,33 +44,21 @@
>  /**
>   * TEST: gem basic
>   * Description: Tests basic gem_create and gem_close IOCTLs
> - *
> - * SUBTEST: bad-close
>   * Category: Infrastructure
> - * Description: Verify that gem_close fails with bad params.
>   * Feature: gem_core
>   * Functionality: driver handler
> - * Run type: BAT
> - * Sub-category: i915
> + * Sub-category: uapi
>   * Test category: GEM_Legacy
> + * Run type: BAT
> + *
> + * SUBTEST: bad-close
> + * Description: Verify that gem_close fails with bad params.
>   *
>   * SUBTEST: create-close
> - * Category: Infrastructure
>   * Description: Verify basic functionality of gem_create and gem_close.
> - * Feature: gem_core
> - * Functionality: driver handler
> - * Run type: BAT
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-fd-close
> - * Category: Infrastructure
>   * Description: Verify that closing drm driver is possible with opened gem object.
> - * Feature: gem_core
> - * Functionality: driver handler
> - * Run type: BAT
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: multigpu-create-close
>   * Description: Verify basic functionality of gem_create and gem_close on multi-GPU.
> diff --git a/tests/intel/gem_blits.c b/tests/intel/gem_blits.c
> index e567cdf33..b9d0b5f87 100644
> --- a/tests/intel/gem_blits.c
> +++ b/tests/intel/gem_blits.c
> @@ -34,7 +34,7 @@
>   * Feature: blitter
>   * Functionality: command streamer
>   * Run type: FULL
> - * Sub-category: HW
> + * Sub-category: CMD submission
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST: basic
> diff --git a/tests/intel/gem_ccs.c b/tests/intel/gem_ccs.c
> index e8f16d7d8..3442ecfd3 100644
> --- a/tests/intel/gem_ccs.c
> +++ b/tests/intel/gem_ccs.c
> @@ -19,11 +19,11 @@
>  /**
>   * TEST: gem ccs
>   * Description: Exercise gen12 blitter with and without flatccs compression
> + * Feature: flat_ccs_mapping
>   * Run type: FULL
>   *
>   * SUBTEST: block-copy-compressed
>   * Description: Check block-copy flatccs compressed blit
> - * Feature: flat_ccs_mapping
>   *
>   * SUBTEST: block-copy-uncompressed
>   * Description: Check block-copy uncompressed blit
> @@ -31,19 +31,16 @@
>   *
>   * SUBTEST: block-multicopy-compressed
>   * Description: Check block-multicopy flatccs compressed blit
> - * Feature: flat_ccs_mapping
>   *
>   * SUBTEST: block-multicopy-inplace
>   * Description: Check block-multicopy flatccs inplace decompression blit
> - * Feature: flat_ccs_mapping
>   *
>   * SUBTEST: ctrl-surf-copy
>   * Description: Check flatccs data can be copied from/to surface
> - * Feature: flat_ccs_mapping
>   *
>   * SUBTEST: ctrl-surf-copy-new-ctx
> - * Description: Check flatccs data are physically tagged and visible in different contexts
> - * Feature: flat_ccs_mapping
> + * Description: Check flatccs data are physically tagged and visible i
> + *		different contexts
>   *
>   * SUBTEST: suspend-resume
>   * Description: Check flatccs data persists after suspend / resume (S0)
> diff --git a/tests/intel/gem_close_race.c b/tests/intel/gem_close_race.c
> index cef0ff025..9c2034ad3 100644
> --- a/tests/intel/gem_close_race.c
> +++ b/tests/intel/gem_close_race.c
> @@ -51,57 +51,42 @@
>  /**
>   * TEST: gem close race
>   * Description: Test try to race gem_close against workload submission.
> - *
> - * SUBTEST: basic-process
>   * Category: Infrastructure
> - * Description: Basic workload submission.
>   * Feature: synchronization
>   * Functionality: driver handler
> - * Run type: BAT
> - * Sub-category: i915
> + * Sub-category: CMD submission
>   * Test category: GEM_Legacy
> + * Run type: FULL
> + *
> + * SUBTEST: basic-process
> + * Description: Basic workload submission.
> + * Run type: BAT
>   *
>   * SUBTEST: basic-threads
> - * Category: Infrastructure
> - * Description:
> - *   Share buffer handle across different drm fd's and trying to race gem_close against
> - *   continuous workload with minimum timeout.
> - * Feature: synchronization
> - * Functionality: driver handler
> + * Description: Share buffer handle across different drm fd's and trying to
> + *		race gem_close against continuous workload with minimum timeout.
>   * Run type: BAT
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: contexts
> - * Description:
> - *   Share buffer handle across different drm fd's and trying to race gem_close against
> - *   continuous workload in other contexts.
> - * Feature: synchronization
> - * Run type: FULL
> + * Description: Share buffer handle across different drm fd's and trying to
> + *		race gem_close against continuous workload in other contexts.
>   *
>   * SUBTEST: gem-close-race
> - * Description:
> - *   Share buffer handle across different drm fd's and trying to race of gem_close against
> - *   continuous workload.
> - * Feature: synchronization
> - * Run type: FULL
> + * Description: Share buffer handle across different drm fd's and trying to
> + *		race of gem_close against continuous workload.
>   *
>   * SUBTEST: multigpu-basic-process
>   * Description: Basic workload submission on multi-GPU machine.
>   * Feature: multigpu, synchronization
> - * Run type: FULL
>   * Test category: MultiGPU
>   *
>   * SUBTEST: multigpu-basic-threads
>   * Description: Run basic-threads race on multi-GPU machine.
>   * Feature: multigpu, synchronization
> - * Run type: FULL
>   * Test category: MultiGPU
>   *
>   * SUBTEST: process-exit
>   * Description: Test try to race gem_close against submission of continuous workload.
> - * Feature: synchronization
> - * Run type: FULL
>   */
>  
>  #define OBJECT_SIZE (256 * 1024)
> diff --git a/tests/intel/gem_create.c b/tests/intel/gem_create.c
> index 87fde2963..77ffceda4 100644
> --- a/tests/intel/gem_create.c
> +++ b/tests/intel/gem_create.c
> @@ -64,101 +64,60 @@
>  #include "i915_drm.h"
>  /**
>   * TEST: gem create
> - * Description:
> - *   Ensure that basic gem_create and gem_create_ext works and that invalid input combinations
> - *   are rejected.
> - * Run type: FULL
> - *
> - * SUBTEST: busy-create
> + * Description: Ensure that basic gem_create and gem_create_ext works and that
> + *		invalid input combinations are rejected.
>   * Category: Infrastructure
> - * Description: Create buffer objects while GPU is busy.
>   * Feature: mapping
>   * Functionality: buffer management
> - * Sub-category: i915
> + * Sub-category: uapi
>   * Test category: GEM_Legacy
> + * Run type: FULL
> + *
> + * SUBTEST: busy-create
> + * Description: Create buffer objects while GPU is busy.
>   *
>   * SUBTEST: create-clear
> - * Category: Infrastructure
>   * Description: Verify that all new objects are clear.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-ext-cpu-access-big
> - * Description:
> - *   Verify the extreme cases with very large objects and.
> - *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
> - * Feature: mapping
> + * Description: Verify the extreme cases with very large objects and
> + *		I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
>   *
>   * SUBTEST: create-ext-cpu-access-sanity-check
> - * Description:
> - *   Verify the basic functionally and expected ABI contract around.
> - *   I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
> - * Feature: mapping
> + * Description: Verify the basic functionally and expected ABI contract around
> + *		I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
>   *
>   * SUBTEST: create-ext-placement-all
>   * Category: Infrastructure
>   * Description: Create objects in every memory region using create_ext.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-ext-placement-each
> - * Category: Infrastructure
> - * Description: Create one object with memory pieces in each memory region using create_ext.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Create one object with memory pieces in each memory region
> + *		using create_ext.
>   *
>   * SUBTEST: create-ext-placement-sanity-check
> - * Category: Infrastructure
>   * Description: Exercise create_ext placements extension.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
>   *
>   * SUBTEST: create-invalid-size
> - * Category: Infrastructure
> - * Description: Try to create a gem object of invalid size 0 and check if ioctl returns error.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Try to create a gem object of invalid size 0 and check if
> + *		ioctl returns error.
>   *
>   * SUBTEST: create-massive
> - * Category: Infrastructure
> - * Description: Exercise creation of buffer object with impossible size and check for the expected error.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Exercise creation of buffer object with impossible size and
> + *		check for the expected error.
>   *
>   * SUBTEST: create-size-update
> - * Category: Infrastructure
> - * Description: Try to create a gem object with size 15 and check actual created size.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Try to create a gem object with size 15 and check actual
> + *		created size.
>   *
>   * SUBTEST: create-valid-nonaligned
> - * Category: Infrastructure
> - * Description:
> - *   Try to create an object with non-aligned size, check we got one with size aligned up to page
> - *   size and test we can write into the padded extra memory.
> - * Feature: mapping
> - * Functionality: buffer management
> - * Sub-category: i915
> - * Test category: GEM_Legacy
> + * Description: Try to create an object with non-aligned size, check we got one
> + *		with size aligned up to page size and test we can write into
> + *		the padded extra memory.
>   *
>   * SUBTEST: hog-create
>   * Description: Create buffer objects while GPU is busy.
> - * Feature: mapping
> - * Test category: GEM_Legacy
> + *
>   */
>  
>  IGT_TEST_DESCRIPTION("Ensure that basic gem_create and gem_create_ext works"
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list