[PATCH] tests/msm_submit: Fix invalid-duplicate-bo-submit errno
Kamil Konieczny
kamil.konieczny at linux.intel.com
Tue Jan 9 12:59:43 UTC 2024
Hi Rob,
On 2024-01-08 at 10:56:38 -0800, Rob Clark wrote:
> From: Rob Clark <robdclark at chromium.org>
>
> With the drm_exec conversion[1], this now returns EALREADY. Which is
> arguablly a fix (better error return code).
>
> [1] kernel commit a6397e63877e ("drm/msm/gem: Convert to drm_exec")
>
> Signed-off-by: Rob Clark <robdclark at chromium.org>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> I'm not sure how much to care about newer igt on older kernel. I think
> I'd be willing to just let this test fail in that case.
>
> tests/msm/msm_submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/msm/msm_submit.c b/tests/msm/msm_submit.c
> index 95f8318facb0..48cffab6940b 100644
> --- a/tests/msm/msm_submit.c
> +++ b/tests/msm/msm_submit.c
> @@ -102,7 +102,7 @@ igt_main
> .nr_bos = ARRAY_SIZE(bos),
> .bos = VOID2U64(bos),
> };
> - do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EINVAL);
> + do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EALREADY);
> }
>
> igt_describe("Check that submit with cmdstream referencing an invalid bo fails");
> --
> 2.43.0
>
More information about the igt-dev
mailing list