[PATCH i-g-t 0/3] Sync i915_pciid.h

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Wed Jan 10 14:45:53 UTC 2024


Set look ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 10.1.2024 10.15, Chaitanya Kumar Borah wrote:
> Our original intent was to add ARL-S PCI IDs to IGT header. The ideal way
> to do that would be to sync i915_pciids.h between kernel and IGT.
> However, recently both files have diverged. See [2]
> 
> We tried adding just the ARL-S PCI ID to the IGT i915_pciids.h but
> this will further diverge both the files. Please see the discussions
> in [1].
> 
> To avoid this, we have decided to use i915_pciids_local.h to move out
> any difference between the kernel and IGT header and then sync both
> the headers.
> 
> I have not tested if the PVC and MTL changes causes any functional issue
> but verified that the build works.
> 
> [1] https://patchwork.freedesktop.org/patch/572027/?series=50957&rev=15
> [2] 17f9914c47c9 (lib: Add Pontevecchio platform)
>      77dd5222d165 (v2: Add mtl to perf-metrics-codegen.py (Umesh))
> 	
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> 
> Chaitanya Kumar Borah (3):
>    lib/i915/perf: include i915_pciids_local.h
>    lib: Add non-kernel macros to i915_pciids_local.h
>    lib: sync i915_pciids.h with kernel
> 
>   lib/i915/perf.c         |  1 +
>   lib/i915_pciids.h       | 56 ++++++++++++++++++-----------------------
>   lib/i915_pciids_local.h | 38 ++++++++++++++++++++++++++++
>   3 files changed, 64 insertions(+), 31 deletions(-)
> 



More information about the igt-dev mailing list