[PATCH i-g-t 2/3] lib: Add non-kernel macros to i915_pciids_local.h

[Borah, Chaitanya Kumar]

Hello Kamil,

> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Sent: Thursday, January 11, 2024 4:39 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>;
> juhapekka.heikkila at gmail.com; Landwerlin, Lionel G
> <lionel.g.landwerlin at intel.com>; Vishwanathapura, Niranjana
> <niranjana.vishwanathapura at intel.com>; Roper, Matthew D
> <matthew.d.roper at intel.com>
> Subject: Re: [PATCH i-g-t 2/3] lib: Add non-kernel macros to
> i915_pciids_local.h
> 
> Hi Chaitanya,
> On 2024-01-10 at 13:45:31 +0530, Chaitanya Kumar Borah wrote:
> > Add MTL and PVC PCI-ID macros which are not present in kernel header
> > to i915_pciids_local.h. This will help us sync the kernel and IGT
> > headers.
> >
> > Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
> > Cc: Matt Roper <matthew.d.roper at intel.com>
> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> > Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura at intel.com>
> > ---
> >  lib/i915_pciids_local.h | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/lib/i915_pciids_local.h b/lib/i915_pciids_local.h index
> > 91c26152a..1ed8364c5 100644
> > --- a/lib/i915_pciids_local.h
> > +++ b/lib/i915_pciids_local.h
> > @@ -7,4 +7,42 @@
> >
> >  #include "i915_pciids.h"
> >
> > +/* MTL perf */
> > +#ifndef INTEL_MTL_M_IDS
> > +#define INTEL_MTL_M_IDS(info) \
> > +       INTEL_VGA_DEVICE(0x7D60, info)
> -- ^
> Please use tabs instead of spaces, here and below.
> 
> You can catch such problems with script checkpatch.pl from linux kernel, here
> you can ignore error on paranthesis in macros but this one needs to be
> corrected. I will do it before merge but please check it yourself in future.
> 

Noted. I missed it among the other warnings.

Thank you. I will take extra care from here onwards.

Regards
Chaitanya

> Regards,
> Kamil
> 
> > +#endif
> > +
> > +#ifndef INTEL_MTL_P_GT2_IDS
> > +#define INTEL_MTL_P_GT2_IDS(info) \
> > +       INTEL_VGA_DEVICE(0x7D45, info) #endif
> > +
> > +#ifndef INTEL_MTL_P_GT3_IDS
> > +#define INTEL_MTL_P_GT3_IDS(info) \
> > +        INTEL_VGA_DEVICE(0x7D55, info), \
> > +        INTEL_VGA_DEVICE(0x7DD5, info) #endif
> > +
> > +#ifndef INTEL_MTL_P_IDS
> > +#define INTEL_MTL_P_IDS(info) \
> > +       INTEL_MTL_P_GT2_IDS(info), \
> > +       INTEL_MTL_P_GT3_IDS(info)
> > +#endif
> > +
> > +/* PVC */
> > +#ifndef INTEL_PVC_IDS
> > +#define INTEL_PVC_IDS(info) \
> > +       INTEL_VGA_DEVICE(0x0BD0, info), \
> > +       INTEL_VGA_DEVICE(0x0BD5, info), \
> > +       INTEL_VGA_DEVICE(0x0BD6, info), \
> > +       INTEL_VGA_DEVICE(0x0BD7, info), \
> > +       INTEL_VGA_DEVICE(0x0BD8, info), \
> > +       INTEL_VGA_DEVICE(0x0BD9, info), \
> > +       INTEL_VGA_DEVICE(0x0BDA, info), \
> > +       INTEL_VGA_DEVICE(0x0BDB, info), \
> > +       INTEL_VGA_DEVICE(0x0BD1, info), \
> > +       INTEL_VGA_DEVICE(0x0BD2, info) #endif
> > +
> >  #endif /* _I915_PCIIDS_LOCAL_H */
> > --
> > 2.25.1
> >