[PATCH v3 2/3] tests/xe_waitfence: Removed drm_xe_sync data in exec_queue_reset_wait

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Jan 11 14:51:16 UTC 2024


On Thu, Jan 11, 2024 at 11:55:17AM +0530, Bommu Krishnaiah wrote:
> Removed drm_xe_sync data in exec_queue_reset_wait since it was declared
> and unused, 

are you sure this is unused? or this is what will force the timeout,
then reset, then the wait_user_fence to really wait to the end?

Cc: Matthew Brost

> failure Intel XE#1081

What is 'Intel XE#1081'?

> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  tests/intel/xe_waitfence.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
> index fd515a151..2f0f00cf4 100644
> --- a/tests/intel/xe_waitfence.c
> +++ b/tests/intel/xe_waitfence.c
> @@ -248,16 +248,8 @@ exec_queue_reset_wait(int fd)
>  		uint32_t data;
>  	} *data;
>  
> -#define USER_FENCE_VALUE        0xdeadbeefdeadbeefull
> -	struct drm_xe_sync sync[1] = {
> -		{ .flags = DRM_XE_SYNC_TYPE_USER_FENCE | DRM_XE_SYNC_FLAG_SIGNAL,
> -			.timeline_value = USER_FENCE_VALUE },
> -	};
> -
>  	struct drm_xe_exec exec = {
>  		.num_batch_buffer = 1,
> -		.num_syncs = 1,
> -		.syncs = to_user_pointer(sync),
>  	};
>  
>  	uint32_t vm = xe_vm_create(fd, 0, 0);
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list