[PATCH i-g-t] tests/intel/xe_exec_atomic: Skip early on unsupported platform

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Jan 19 12:50:49 UTC 2024


Hi Nirmoy,
On 2024-01-19 at 11:18:44 +0100, Nirmoy Das wrote:
> Skip early if the test is not supported without
> creating a dynamic subtest.
> 
> Signed-off-by: Nirmoy Das <nirmoy.das at intel.com>
> ---
>  tests/intel/xe_exec_atomic.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/intel/xe_exec_atomic.c b/tests/intel/xe_exec_atomic.c
> index a21def999..209df8419 100644
> --- a/tests/intel/xe_exec_atomic.c
> +++ b/tests/intel/xe_exec_atomic.c
> @@ -137,14 +137,14 @@ igt_main
>  
>  			xe_for_each_mem_region(fd, memreg, region) {
>  
> +					igt_skip_on(!has_atomics(fd, region));
> +

Fix indentation.

>  				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
>  					      xe_engine_class_string(hwe->engine_class),
>  					      hwe->engine_instance,
> -					      hwe->gt_id, xe_region_name(region)) {
> +					      hwe->gt_id, xe_region_name(region))
>  
> -					igt_skip_on(!has_atomics(fd, region));
>  					basic_inst(fd, MI_ATOMIC_DEC, hwe, region);
> -				}
>  			}
>  		}
>  	}
> @@ -155,14 +155,14 @@ igt_main
>  
>  			xe_for_each_mem_region(fd, memreg, region) {
>  
> +					igt_skip_on(!has_atomics(fd, region));
> +

Fix indentation.

With that fixed:
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

>  				igt_dynamic_f("Engine-%s-Instance-%d-Tile-%d-%s-memory",
>  					      xe_engine_class_string(hwe->engine_class),
>  					      hwe->engine_instance,
> -					      hwe->gt_id, xe_region_name(region)) {
> +					      hwe->gt_id, xe_region_name(region))
>  
> -					igt_skip_on(!has_atomics(fd, region));
>  					basic_inst(fd, MI_ATOMIC_INC, hwe, region);
> -				}
>  			}
>  		}
>  	}
> -- 
> 2.42.0
> 


More information about the igt-dev mailing list