[PATCH v4 1/3] tests/xe_waitfence: remove invalid_engine subtest from xe_waitfence
Rodrigo Vivi
rodrigo.vivi at intel.com
Mon Jan 22 20:53:15 UTC 2024
On Mon, Jan 22, 2024 at 08:15:41AM +0530, Bommu Krishnaiah wrote:
> engine and instance members are removed from drm_xe_wait_user_fence,
> hence invalid_engine subtest is invalid and removing it.
>
> kernel implementation:
> https://patchwork.freedesktop.org/series/127365/
>
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> tests/intel/xe_waitfence.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/tests/intel/xe_waitfence.c b/tests/intel/xe_waitfence.c
> index 7ba20764c..dfdb97fb5 100644
> --- a/tests/intel/xe_waitfence.c
> +++ b/tests/intel/xe_waitfence.c
> @@ -151,9 +151,6 @@ waitfence(int fd, enum waittype wt)
> * SUBTEST: invalid-ops
> * Description: Check query with invalid ops returns expected error code
> *
> - * SUBTEST: invalid-engine
> - * Description: Check query with invalid engine info returns expected error code
> - *
> * SUBTEST: exec_queue-reset-wait
> * Description: Don’t wait till timeout on user fence when exec_queue reset is detected and return return proper error
> */
> @@ -206,30 +203,6 @@ invalid_ops(int fd)
> do_ioctl_err(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait, EINVAL);
> }
>
> -static void
> -invalid_engine(int fd)
> -{
> - uint32_t bo;
> -
> - struct drm_xe_wait_user_fence wait = {
> - .addr = to_user_pointer(&wait_fence),
> - .op = DRM_XE_UFENCE_WAIT_OP_EQ,
> - .flags = 0,
> - .value = 1,
> - .mask = DRM_XE_UFENCE_WAIT_MASK_U64,
> - .timeout = -1,
> - .exec_queue_id = 0,
> - };
> -
> - uint32_t vm = xe_vm_create(fd, 0, 0);
> -
> - bo = xe_bo_create(fd, vm, 0x40000, vram_if_possible(fd, 0), 0);
> -
> - do_bind(fd, vm, bo, 0, 0x200000, 0x40000, 1);
> -
> - do_ioctl_err(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait, EFAULT);
> -}
> -
> static void
> exec_queue_reset_wait(int fd)
> {
> @@ -329,9 +302,6 @@ igt_main
> igt_subtest("invalid-ops")
> invalid_ops(fd);
>
> - igt_subtest("invalid-engine")
> - invalid_engine(fd);
> -
> igt_subtest("exec_queue-reset-wait")
> exec_queue_reset_wait(fd);
>
> --
> 2.25.1
>
More information about the igt-dev
mailing list