[PATCH i-g-t] lib/xe: Boost prefetch size to 4KB

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Wed Jan 24 04:43:45 UTC 2024


On Tue, Jan 23, 2024 at 12:18:19PM -0600, Lucas De Marchi wrote:
> On Tue, Jan 23, 2024 at 06:56:36AM +0100, Zbigniew Kempczyński wrote:
> > On Mon, Jan 22, 2024 at 10:22:29AM -0600, Lucas De Marchi wrote:
> > > On Mon, Jan 22, 2024 at 03:43:02PM +0000, Matthew Auld wrote:
> > > > From: Lucas De Marchi <lucas.demarchi at intel.com>
> > > >
> > > > For Xe2, the prefetch for RCS is 4KB, so boost it.
> > > >
> > > > BSpec: 60223
> > > > Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> > > > Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> > > > Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > > 
> > > 
> > > humn... looks like I forgot to merge this?
> > > 
> > > pushed now. Thanks for the reminder.
> > 
> > Nice, but where's r-b?
> 
> Note the 2 s-o-b, with me being the author of the patch.
> It wouldn't make sense for me to add a r-b on my own
> patch.
> 
> Would it make sense if Matthew added his? Maybe, but I don't think
> there's a real need in this oneliner where 2 devs agreed on the
> implementation.
> 
> Lucas De Marchi

In this case change is safe but I would like to avoid merging
code without r-b. Multiple s-o-b's don't replace review - otherwise
we could upstream most of the code without r-b, couldn't we?

Anyway - we can close this thread.

--
Zbigniew


More information about the igt-dev mailing list