[PATCH i-g-t 0/3] lib/kunit: Support writable filter* parameters of kunit module

Janusz Krzysztofik janusz.krzysztofik at linux.intel.com
Fri Jan 26 13:14:34 UTC 2024


Hi Lucas,

Thanks for looking at this.

On Thursday, 25 January 2024 18:25:55 CET Lucas De Marchi wrote:
> On Thu, Jan 25, 2024 at 05:52:09PM +0100, Janusz Krzysztofik wrote:
> >Instead of wasting resources on reloading the base Kunit module each time
> >a different set of filter parameters is needed, try to write the required
> >values to sysfs representation of those parameters.  If that fails (e.g.
> >on older LTS kernels with read-only filter parameters), fall back to
> 
> we can't really execute anything on LTS kernel. 

Yes, we can, and we do, since modules of DRM generic selftests like drm_buddy 
or drm_mm and a couple of KMS related ones were converted from i915 selftest 
format to KUnit and our IGT counterparts that load those modules and execute 
those tests were updated accordingly.  Maybe our CI no longer exercises IGT 
tests on LTS kernels, but the community may still do, I believe.

Thanks,
Janusz


> I don't think think it's
> worth keeping the multiple fallbacks we have now.
> 
> I think trying to maintain compat is good, but I'm not sure it makes
> sense for these tightly coupled tests with the kernel.
> 
> Lucas De Marchi
> 






More information about the igt-dev mailing list