[PATCH i-g-t 34/37] tests/kms_ccs: Correctly check clear color for fp16 formats

Ville Syrjala ville.syrjala at linux.intel.com
Tue Jul 2 23:28:14 UTC 2024


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

The hardware generated clear color will be in the native
pixel format. Generate the reference correctly for fp16
formats.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/intel/kms_ccs.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/tests/intel/kms_ccs.c b/tests/intel/kms_ccs.c
index 4c1c78ee4e58..5c18868a062f 100644
--- a/tests/intel/kms_ccs.c
+++ b/tests/intel/kms_ccs.c
@@ -35,6 +35,7 @@
  */
 
 #include "igt.h"
+#include "igt_halffloat.h"
 
 #include "i915/gem_create.h"
 #include "intel_pat.h"
@@ -198,6 +199,7 @@ static const uint32_t formats[] = {
 	DRM_FORMAT_XYUV8888,
 	DRM_FORMAT_XRGB8888,
 	DRM_FORMAT_XRGB2101010,
+	DRM_FORMAT_XBGR16161616F,
 	DRM_FORMAT_YUYV,
 	DRM_FORMAT_NV12,
 	DRM_FORMAT_P012,
@@ -321,7 +323,8 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float
 		uint32_t d;
 	} *cc_p;
 	void *map;
-	uint32_t native_color = 0;
+	uint32_t native_color[2] = {};
+	uint16_t half[4];
 
 	if (is_i915_device(drm_fd)) {
 		gem_set_domain(drm_fd, fb->gem_handle, I915_GEM_DOMAIN_CPU, 0);
@@ -338,25 +341,32 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float
 
 	switch (fb->drm_format) {
 	case DRM_FORMAT_XRGB8888:
-		native_color = (uint32_t)(cc_color[3] * 0xff) << 24 |
+		native_color[0] = (uint32_t)(cc_color[3] * 0xff) << 24 |
 			(uint32_t)(cc_color[0] * 0xff) << 16 |
 			(uint32_t)(cc_color[1] * 0xff) << 8 |
 			(uint32_t)(cc_color[2] * 0xff);
 		break;
 	case DRM_FORMAT_XRGB2101010:
-		native_color = (uint32_t)(cc_color[3] * 0x3) << 30 |
+		native_color[0] = (uint32_t)(cc_color[3] * 0x3) << 30 |
 			(uint32_t)(cc_color[0] * 0x3ff) << 20 |
 			(uint32_t)(cc_color[1] * 0x3ff) << 10 |
 			(uint32_t)(cc_color[2] * 0x3ff);
 		break;
+	case DRM_FORMAT_XBGR16161616F:
+		igt_float_to_half(cc_color, half, 4);
+
+		native_color[1] = (uint64_t)half[3] << 16 | (uint64_t)half[2];
+		native_color[0] = (uint64_t)half[1] << 16 | (uint64_t)half[0];
+		break;
 	default:
 		break;
 	}
 
-	igt_assert(native_color == cc_p[4].d);
+	igt_assert(native_color[0] == cc_p[4].d);
+	igt_assert(native_color[1] == cc_p[5].d);
 
 	igt_assert(gem_munmap(map, fb->size) == 0);
-};
+}
 
 static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color, bool check_cc_plane)
 {
@@ -857,7 +867,8 @@ static bool try_config(data_t *data, enum test_fb_flags fb_flags,
 
 	if (igt_fb_is_gen12_rc_ccs_cc_modifier(data->ccs_modifier) &&
 	    data->format != DRM_FORMAT_XRGB8888 &&
-	    data->format != DRM_FORMAT_XRGB2101010)
+	    data->format != DRM_FORMAT_XRGB2101010 &&
+	    data->format != DRM_FORMAT_XBGR16161616F)
 		return false;
 
 	if ((fb_flags & FB_MISALIGN_AUX_STRIDE) ||
-- 
2.44.2



More information about the igt-dev mailing list