[i-g-t 4/4] tests/kms_vrr: Fix virtual mode for CMRR subtest

Golani, Mitulkumar Ajitkumar mitulkumar.ajitkumar.golani at intel.com
Wed Jul 3 05:20:34 UTC 2024



> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Sent: Friday, June 21, 2024 2:17 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; Golani,
> Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani at intel.com>
> Subject: [i-g-t 4/4] tests/kms_vrr: Fix virtual mode for CMRR subtest
> 
> Instead of tweaking the mode->clock, change the mode->vtotal to create the
> virtual mode.
> 
> Cc: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_vrr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 6f90f4729..f12d23c3c
> 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -809,9 +809,9 @@ test_cmrr(data_t *data, enum pipe pipe, igt_output_t
> *output, uint32_t flags)
>  	kmstest_dump_mode(&mode);
> 
>  	if (!found) {
> -		igt_info("No CMRR mode found on %s, try to tweak the
> clock.\n", output->name);
> +		igt_info("No CMRR mode found on %s, try to tweak the
> mode.\n",
> +output->name);
> 
> -		mode.clock = (mode.htotal * mode.vtotal * (mode.vrefresh +
> VREFRESH_MODIFIER)) / 1000;
> +		virtual_rr_vrr_range_mode(&mode, mode.vrefresh +
> VREFRESH_MODIFIER);

Hi Bhanu,

in CMRR, with underlying changes, in response to clock tweaks, vtotal is inc/dec by 1 scanline to match with requested fps. Now here with test itself we tweak into vtotal.
> 
>  		igt_info("Tweaked mode: ");
>  		kmstest_dump_mode(&mode);
> --
> 2.43.2



More information about the igt-dev mailing list