[PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests

[Kolakowski, Jakub1]

Hi Michał,

I have just sent patch with corrections applied.

-----Original Message-----
From: Wajdeczko, Michal <Michal.Wajdeczko at intel.com> 
Sent: Thursday, July 4, 2024 4:21 PM
To: Kolakowski, Jakub1 <jakub1.kolakowski at intel.com>; igt-dev at lists.freedesktop.org
Cc: Miszczak, Adam <adam.miszczak at intel.com>; Bernatowicz, Marcin <marcin.bernatowicz at intel.com>; Laguna, Lukasz <lukasz.laguna at intel.com>; Kamil Konieczny <kamil.konieczny at linux.intel.com>
Subject: Re: [PATCH i-g-t] tests/intel-ci/fast-feedback: Add SR-IOV tests



> On 03.07.2024 13:12, Jakub Kolakowski wrote:
>> This commit adds SR-IOV tests to fast-feedback testlist so that
>
> nit: not sure about IGT rules, but usually we don't start commit message with "This commit", from [1]
>
> "Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
> instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as if you are giving orders to the codebase to change its behaviour."
>
>
> [1] https://docs.kernel.org/process/submitting-patches.html
>
>> they will be executed in BAT runs. Added tests are about basic single 
>> VF enablement with and without autoprobe.
>> 
>> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski at intel.com>
>> Cc: Adam Miszczak <adam.miszczak at intel.com>
>> Cc: Marcin Bernatowicz <marcin.bernatowicz at intel.com>
>> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
>> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
>> ---
>>  tests/intel-ci/xe-fast-feedback.testlist | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/tests/intel-ci/xe-fast-feedback.testlist 
>> b/tests/intel-ci/xe-fast-feedback.testlist
>> index aa98b37e6..fc312a123 100644
>> --- a/tests/intel-ci/xe-fast-feedback.testlist
>> +++ b/tests/intel-ci/xe-fast-feedback.testlist
>> @@ -65,6 +65,8 @@ igt at kms_prop_blob@basic  
>> igt at kms_psr@psr-primary-page-flip  igt at kms_psr@psr-cursor-plane-move  
>> igt at kms_psr@psr-sprite-plane-onoff
>> +igt at sriov_basic@enable-vfs-autoprobe-off at numvfs-1
>
> maybe instead of numvfs-1 we should select numvfs-all variant:
>
>	igt at sriov_basic@enable-vfs-autoprobe-off at numvfs-all
>
> as otherwise this case will be fully duplicated by the test below (where auto-provisioning of one VF will be exactly the same, just a VF driver will be probed on that config), while with numvfs-all variant we will check auto-provisioning for all available VFs
>
>> +igt at sriov_basic@enable-vfs-autoprobe-on at numvfs-1
>>  igt at xe_compute@compute-square
>>  igt at xe_create@create-execqueues-noleak
>>  igt at xe_create@create-execqueues-leak
>