[PATCH i-g-t 2/2] tests/sriov_basic: Extract enable-vfs-bind-unbind-each-numvfs-all subtest

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Marcin Bernatowicz
Sent: Wednesday, July 10, 2024 8:25 AM
To: igt-dev at lists.freedesktop.org
Cc: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>; Adam Miszczak <adam.miszczak at linux.intel.com>; Laguna, Lukasz <lukasz.laguna at intel.com>; Kolakowski, Jakub1 <jakub1.kolakowski at intel.com>; Wajdeczko, Michal <Michal.Wajdeczko at intel.com>
Subject: [PATCH i-g-t 2/2] tests/sriov_basic: Extract enable-vfs-bind-unbind-each-numvfs-all subtest
> 
> Extract the 'enable-vfs-bind-unbind-each-numvfs-all' subtest to
> simplify blocklist management. Currently, there is no straightforward
> method to block dynamic subsubtests, and running all of them becomes
> too time-consuming.

My comment for the previous patch applies here as well.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> 
> Cc: Adam Miszczak <adam.miszczak at linux.intel.com>
> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski at intel.com>
> Cc: Michal Wajdeczko <Michal.Wajdeczko at intel.com>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> ---
>  tests/sriov_basic.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/sriov_basic.c b/tests/sriov_basic.c
> index 95a462709..36bca4149 100644
> --- a/tests/sriov_basic.c
> +++ b/tests/sriov_basic.c
> @@ -62,7 +62,12 @@ static void enable_vfs_autoprobe_on(int pf_fd, unsigned int num_vfs)
>  /**
>   * SUBTEST: enable-vfs-bind-unbind-each
>   * Description:
> - *   Verify VFs enabling with binding and unbinding the driver one be one to each of them
> + *   Verify VFs enabling with binding and unbinding the driver one by one to each of them.
> + *   Version includes dynamic subtests that allow specifying the number of enabled VFs as numvfs-N.
> + *
> + * SUBTEST: enable-vfs-bind-unbind-each-numvfs-all
> + * Description:
> + *   Verify the enabling of all VFs and the sequential binding and unbinding of the driver to each one.
>   */
>  static void enable_vfs_bind_unbind_each(int pf_fd, unsigned int num_vfs)
>  {
> @@ -176,10 +181,12 @@ igt_main
>  				enable_vfs_bind_unbind_each(pf_fd, num_vfs);
>  			}
>  		}
> +	}
> +
> +	igt_describe("Verify the enabling of all VFs and the sequential binding and unbinding of the driver to each one");
> +	igt_subtest("enable-vfs-bind-unbind-each-numvfs-all") {
>  		for_max_sriov_num_vfs(pf_fd, num_vfs) {
> -			igt_dynamic_f("numvfs-all") {
> -				enable_vfs_bind_unbind_each(pf_fd, num_vfs);
> -			}
> +			enable_vfs_bind_unbind_each(pf_fd, num_vfs);
>  		}
>  	}
>  
> -- 
> 2.31.1
> 
>