[PATCH i-g-t 3/5] lib/gem_engine_topology: Fix premature break from primary find loop
Janusz Krzysztofik
janusz.krzysztofik at linux.intel.com
Mon Jul 15 18:13:44 UTC 2024
When looking for a primary counterpart of a render device, we try to open
each primary minor. When one fails, we should continue rather then break,
since contiguity of minor numbers assigned to devices is not guaranteed.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
---
lib/i915/gem_engine_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
index ac9e8e9b1b..79984421b2 100644
--- a/lib/i915/gem_engine_topology.c
+++ b/lib/i915/gem_engine_topology.c
@@ -479,7 +479,7 @@ static int __open_primary(int dir)
sprintf(buf, "/sys/dev/char/%d:%d", major, minor);
dir = openat(fd, buf, O_RDONLY);
if (dir < 0)
- break;
+ continue;
if (readlinkat(dir, "device", device, sizeof(device)) > 0 &&
!strcmp(device, target))
--
2.45.2
More information about the igt-dev
mailing list