[PATCH i-g-t 2/3] lib/kunit: Drop 'suite' from __igt_kunit arguments list

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Jul 22 08:49:13 UTC 2024


On Mon, Jul 22, 2024 at 10:01:03AM +0200, Janusz Krzysztofik wrote:
> The optional 'suite' argument was used as a KUnit filter_glob when we were
> loading KUnit test module once per IGT subtest.  Since we are now loading
> the module once per IGT dynamic sub-subtest, we use test_suite.test_case
> obtained from a list of test cases as filter_glob.  Drop the no longer
> used argument.
> 
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
> ---
>  lib/igt_kmod.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index 5864be29d2..a13c6fe063 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -1333,7 +1333,6 @@ static bool kunit_get_tests(struct igt_list_head *tests,
>  
>  static void __igt_kunit(struct igt_ktest *tst,
>  			const char *subtest,
> -			const char *suite,
>  			const char *opts,
>  			const char *debugfs_path,
>  			struct igt_list_head *tests,
> @@ -1486,7 +1485,7 @@ void igt_kunit(const char *module_name, const char *suite, const char *opts)
>  		    !kunit_get_tests(&tests, &tst, suite, opts, debugfs_path, &debugfs_dir, &ktap))
>  			__igt_kunit_legacy(&tst, subtest, opts);
>  		else
> -			__igt_kunit(&tst, subtest, suite, opts, debugfs_path, &tests, &ktap);
> +			__igt_kunit(&tst, subtest, opts, debugfs_path, &tests, &ktap);
>  	}
>  
>  	igt_fixture {
> -- 
> 2.45.2
> 

LGTM:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list