[PATCH i-g-t 3/3] lib/kunit: Improve a comment on action=list parameter
Zbigniew Kempczyński
zbigniew.kempczynski at intel.com
Mon Jul 22 08:55:53 UTC 2024
On Mon, Jul 22, 2024 at 10:01:04AM +0200, Janusz Krzysztofik wrote:
> Emphasize the fact that test case list of unknown length we want to avoid
> parsing of is an unstructured free text list.
>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
> ---
> lib/igt_kmod.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index a13c6fe063..464c0dcf48 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -1284,10 +1284,10 @@ static bool kunit_get_tests(struct igt_list_head *tests,
> /*
> * To get a list of test cases provided by a kunit test module, ask the
> * generic kunit module to respond with SKIP result for each test found.
> - * We could also use action=list kunit parameter to get the listing,
> - * however, parsing a KTAP report -- something that we already can do
> - * perfectly -- seems to be more safe than extracting a test case list
> - * of unknown length from /dev/kmsg.
> + * We could also try to use action=list kunit parameter to get the
> + * listing, however, parsing a structured KTAP report -- something that
> + * we already can do perfectly -- seems to be more safe than extracting
> + * a free text list of unknown length from /dev/kmsg.
> */
> if (igt_debug_on(!kunit_set_filtering(suite, "module=none", "skip")))
> return false;
> --
> 2.45.2
>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
--
Zbigniew
More information about the igt-dev
mailing list