[PATCH i-g-t] tests/xe_query: Also allow IP version less than 20 for BMG media

Gustavo Sousa gustavo.sousa at intel.com
Mon Jul 22 19:21:45 UTC 2024


Quoting Matt Roper (2024-07-22 15:35:10-03:00)
>Since BMG has a media version of 13.01, MTL/ARL are no longer the only
>cases where we'll see IP versions lower than 20.  Add one more exception
>to the final GT IP version sanity check.
>
>Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2238
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
>---
> tests/intel/xe_query.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
>index 84df24f49..c13613e0a 100644
>--- a/tests/intel/xe_query.c
>+++ b/tests/intel/xe_query.c
>@@ -331,11 +331,16 @@ test_query_gt_list(int fd)
>                                 igt_assert_lte(1270, verx100);
> 
>                         /*
>-                         * Aside from MTL/ARL, all version numbers should be
>-                         * 20.00 or higher.
>+                         * Aside from MTL/ARL and media on BMG, all version
>+                         * numbers should be 20.00 or higher.
>                          */
>-                        if (!IS_METEORLAKE(dev_id))
>-                                igt_assert_lte(20, gt_list->gt_list[i].ip_ver_major);
>+                        if (IS_METEORLAKE(dev_id))
>+                                continue;
>+                        if (gt_list->gt_list[i].type == DRM_XE_QUERY_GT_TYPE_MEDIA &&
>+                            IS_BATTLEMAGE(dev_id))
>+                                continue;
>+
>+                        igt_assert_lte(20, gt_list->gt_list[i].ip_ver_major);

I get the impression that this section could be refactored so that we
define the minimum expected verx100 and have a single igt_assert_lte().
Up to you though.

Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

>                 }
>         }
> }
>-- 
>2.45.2
>


More information about the igt-dev mailing list