[PATCH i-g-t v3 4/4] tests/vmwgfx: Fix and extend the reference counting test
Zack Rusin
zack.rusin at broadcom.com
Mon Jul 29 03:35:23 UTC 2024
On Fri, Jul 26, 2024 at 3:16 PM Kamil Konieczny
<kamil.konieczny at linux.intel.com> wrote:
>
> Hi Zack,
> On 2024-06-28 at 15:02:43 -0400, Zack Rusin wrote:
> > Fix a few issues related to buffer managment in the reference counting
> > test. Extend it to include various prime related reference counting
> > issues.
> >
> > Signed-off-by: Zack Rusin <zack.rusin at broadcom.com>
>
> Sorry for late response. Could you split fixes from improvements?
It's really not worth it. The test is only valuable with all the
changes. If it makes it better I can remove it altogether in one
change and re-add it in its current form in the other but that seems
silly.
> > ---
> > lib/igt_vmwgfx.c | 45 +++-----
> > lib/igt_vmwgfx.h | 30 +----
> > tests/vmwgfx/vmw_ref_count.c | 207 +++++++++++++++++++++++++++++------
> > 3 files changed, 193 insertions(+), 89 deletions(-)
> >
> > diff --git a/lib/igt_vmwgfx.c b/lib/igt_vmwgfx.c
> > index d2f699575..b62d7a326 100644
> > --- a/lib/igt_vmwgfx.c
> > +++ b/lib/igt_vmwgfx.c
> > @@ -1,28 +1,8 @@
> > // SPDX-License-Identifier: GPL-2.0 OR MIT
> > -/**********************************************************
> > - * Copyright 2021-2023 VMware, Inc.
>
> Please do not remove old copyrigths.
I'm sorry but I can not do that. Broadcom acquired VMware, this is how
those copyrights have to look. You'd have to go through Broadcom's
legal team to contest this.
I'll respin the series with checkpatch.pl fixes.
z
More information about the igt-dev
mailing list