[PATCH i-g-t v2 01/10] tests/intel/xe_drm_fdinfo: Rename basic to basic-memory test

[Kamil Konieczny]

Hi Lucas,
On 2024-07-11 at 15:36:16 -0500, Lucas De Marchi wrote:
> On Thu, Jul 11, 2024 at 10:39:28AM GMT, Umesh Nerlige Ramappa wrote:
> > On Thu, Jul 11, 2024 at 07:00:40AM -0500, Lucas De Marchi wrote:
> > > On Tue, Jul 02, 2024 at 05:25:23PM GMT, Umesh Nerlige Ramappa wrote:
> > > > Existing basic test is checking memory info in fdinfo. Rename
> > > > accordingly.
> > > > 
> > > > Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> > > > ---
> > > > tests/intel/xe_drm_fdinfo.c | 12 ++++++------
> > > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/tests/intel/xe_drm_fdinfo.c b/tests/intel/xe_drm_fdinfo.c
> > > > index 2ceafba24..f0aa23e2f 100644
> > > > --- a/tests/intel/xe_drm_fdinfo.c
> > > > +++ b/tests/intel/xe_drm_fdinfo.c
> > > 
> > > I was also expecting a change to the testlist... but it seems we don't
> > > really have this there.
> > > 
> > > https://intel-gfx-ci.01.org/tree/intel-xe/index.html?testfilter=xe_drm_fdinfo
> > > returns an empty result so it seems we are not even running these tests?
> > 
> > Strange, for rev2 I actually saw these new tests run in the shards list
> > and was expecting the same for newer revs.
> > 
> > https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11334/shards-all.html?testfilter=xe_drm_fdinfo
> 
> yeah... if I use the shards-all.html I can see it.. and that one doesn't
> need a testlist since it's actually "all the tests".

We need change only for hard-coded xe-fast-feedback or if it was
in blocklist. Btw is this correct:

xe.blocklist.txt:igt at drm_fdinfo

imho this should also be running in our tests? Or am I missing something?

Regards,
Kamil

> 
> Lucas De Marchi
> 
> > 
> > Umesh
> > 
> > > 
> > > Cc'ing some people. For the changes here:
> > > 
> > > Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
> > > 
> > > thanks
> > > Lucas De Marchi
> > > 
> > > > @@ -22,8 +22,8 @@
> > > > * Feature: SMI, core
> > > > * Test category: SysMan
> > > > *
> > > > - * SUBTEST: basic
> > > > - * Description: Check if basic fdinfo content is present
> > > > + * SUBTEST: basic-memory
> > > > + * Description: Check if basic fdinfo content is present for memory
> > > > *
> > > > * SUBTEST: drm-total-resident
> > > > * Description: Create and compare total and resident memory consumption by client
> > > > @@ -259,7 +259,7 @@ static void test_total_resident(int xe)
> > > > 	xe_vm_destroy(xe, vm);
> > > > }
> > > > 
> > > > -static void basic(int xe)
> > > > +static void basic_memory(int xe)
> > > > {
> > > > 	struct drm_xe_mem_region *memregion;
> > > > 	uint64_t memreg = all_memory_regions(xe), region;
> > > > @@ -299,9 +299,9 @@ igt_main
> > > > 		igt_require(igt_parse_drm_fdinfo(xe, &info, NULL, 0, NULL, 0));
> > > > 	}
> > > > 
> > > > -	igt_describe("Check if basic fdinfo content is present");
> > > > -	igt_subtest("basic")
> > > > -		basic(xe);
> > > > +	igt_describe("Check if basic fdinfo content is present for memory");
> > > > +	igt_subtest("basic-memory")
> > > > +		basic_memory(xe);
> > > > 
> > > > 	igt_describe("Create and compare total and resident memory consumption by client");
> > > > 	igt_subtest("drm-total-resident")
> > > > -- 
> > > > 2.38.1
> > > >