[PATCH i-g-t 01/12] lib/intel_bufops: Fix offset returned for Tile4

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Mon Jun 3 07:26:15 UTC 2024


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 27.5.2024 10.33, Zbigniew Kempczyński wrote:
> Functions which calculates offset in bufops for specific tiling should
> return it in bytes, not in cpp. Fix this issue for Tile4.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>   lib/intel_bufops.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
> index 52a5f322ea..313c2665ae 100644
> --- a/lib/intel_bufops.c
> +++ b/lib/intel_bufops.c
> @@ -377,7 +377,6 @@ static void *tile4_ptr(void *ptr,
>   		((tile_y & 3) << __builtin_ctz(owords)) +
>   		(tile_x & (owords - 1));
>   	igt_assert((pos & (cpp - 1)) == 0);
> -	pos = pos >> __builtin_ctz(cpp);
>   
>   	return ptr + pos;
>   }



More information about the igt-dev mailing list