[PATCH] tests/intel/xe_exec_fault_mode: enable copy engine testing for invalid-va

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jun 5 10:54:05 UTC 2024


Hi Andrzej,
On 2024-06-04 at 17:12:44 +0200, Andrzej Hajda wrote:
> Testing copy engine was skipped due to kernel bug. Since bug was
------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^
imho we should not skip a test due to kernel bug, what we can do
is to add it temporarily to blocklist or just keep it as gitlab
ticket to be fixed. Or we were not sure if it was a bug?

> fixed in kernel [1] we can test all engines.
> 
> [1]: 38007fa96419 ("drm/xe: flush gtt before signalling user fence on all engines")
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

> ---
>  tests/intel/xe_exec_fault_mode.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/intel/xe_exec_fault_mode.c b/tests/intel/xe_exec_fault_mode.c
> index f3d2e07ecb32..26d339f5aa58 100644
> --- a/tests/intel/xe_exec_fault_mode.c
> +++ b/tests/intel/xe_exec_fault_mode.c
> @@ -448,11 +448,8 @@ igt_main
>  	}
>  
>  	igt_subtest("invalid-va")
> -		xe_for_each_engine(fd, hwe) {
> -			if (hwe->engine_class == DRM_XE_ENGINE_CLASS_COPY)
> -			       continue;	
> +		xe_for_each_engine(fd, hwe)
>  			test_exec(fd, hwe, 1, 1, INVALID_VA);
> -		}
>  
>  	igt_subtest("invalid-va-scratch-nopagefault")
>  		xe_for_each_engine(fd, hwe)
> 
> ---
> base-commit: f3006a13799e3bc45d754aa8ad318394277d69ac
> change-id: 20240522-xe_exec_fault_mode-invalid-va_enable_bcs-5b82ba2badfc
> 
> Best regards,
> -- 
> Andrzej Hajda <andrzej.hajda at intel.com>
> 


More information about the igt-dev mailing list