[PATCH i-g-t RFC 11/13] tests/chamelium: Introduce test resolution

Louis Chauvet louis.chauvet at bootlin.com
Wed Jun 5 14:30:23 UTC 2024


Introduce a new tests to ensures that the resolution listed and used by
the DRM device is correct according to the EDID.

This is inspired from the v2 version.

Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
---
 tests/chamelium/v3/kms_chamelium_v3_edid.c | 103 ++++++++++++++++++++++++++++-
 1 file changed, 102 insertions(+), 1 deletion(-)

diff --git a/tests/chamelium/v3/kms_chamelium_v3_edid.c b/tests/chamelium/v3/kms_chamelium_v3_edid.c
index 836086f2dc13..a85091a3c660 100644
--- a/tests/chamelium/v3/kms_chamelium_v3_edid.c
+++ b/tests/chamelium/v3/kms_chamelium_v3_edid.c
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 
 #include <igt.h>
+
 #include "monitor_edids/monitor_edids_helper.h"
 #include "chamelium/v3/igt_chamelium.h"
 
@@ -70,6 +71,89 @@ static void edid_stress_resolution(int drm_fd, struct igt_chamelium_rpc *chameli
 	}
 }
 
+static void edid_resolution_list(int drm_fd, struct igt_chamelium_rpc *chamelium,
+				 struct chamelium_rpc_port_mapping *port_mapping)
+{
+	int screen_res_w, screen_res_h;
+	drmModeConnector *connector;
+	chamelium_edid_id edid_id;
+	drmModeModeInfoPtr modes;
+	struct igt_fb fb = {0};
+	igt_display_t display;
+	bool is_video_stable;
+	igt_output_t *output;
+	igt_plane_t *primary;
+	int count_modes, i;
+	enum pipe pipe;
+
+	chamelium_reset_rpc(chamelium);
+
+	edid_id = chamelium_create_edid_rpc(chamelium,
+					    igt_kms_get_custom_edid(IGT_CUSTOM_EDID_BASE));
+	chamelium_apply_edid_rpc(chamelium, port_mapping->port_id, edid_id);
+
+	chamelium_plug_rpc(chamelium, port_mapping->port_id);
+
+	connector = chamelium_rpc_port_mapping_get_connector(port_mapping, drm_fd);
+	assert(igt_wait_for_connector_status(drm_fd, connector->connector_id, 10.0,
+					     DRM_MODE_CONNECTED));
+	drmModeFreeConnector(connector);
+
+	connector = chamelium_rpc_port_mapping_get_connector(port_mapping, drm_fd);
+	modes = connector->modes;
+	count_modes = connector->count_modes;
+
+	igt_display_require(&display, drm_fd);
+	igt_require(display.is_atomic);
+	igt_display_require_output(&display);
+
+	for (i = 0; i < count_modes; ++i)
+		igt_debug("#%d %s %uHz\n", i, modes[i].name, modes[i].vrefresh);
+
+	for (i = 0; i < count_modes; ++i) {
+		igt_info("Testing #%d %s %uHz\n", i, modes[i].name,
+			 modes[i].vrefresh);
+
+		igt_display_reset(&display);
+
+		output = igt_output_from_connector(&display, connector);
+		igt_assert(output);
+		pipe = igt_get_pipe_for_output(&display, output);
+		igt_output_set_pipe(output, pipe);
+
+		/* Set the screen mode with the one we chose. */
+		igt_create_color_fb(drm_fd, modes[i].hdisplay, modes[i].vdisplay,
+				    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, 1, 0, 0, &fb);
+
+		primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+		igt_assert(primary);
+
+		igt_plane_set_fb(primary, &fb);
+		igt_fb_set_size(&fb, primary, modes[i].hdisplay, modes[i].vdisplay);
+		igt_plane_set_size(primary, modes[i].hdisplay, modes[i].vdisplay);
+
+		igt_output_override_mode(output, &modes[i]);
+
+		igt_display_commit2(output->display, COMMIT_ATOMIC);
+
+		is_video_stable = chamelium_port_wait_video_input_stable_rpc(chamelium,
+									     port_mapping->port_id,
+									     10);
+		igt_assert(is_video_stable);
+
+		chamelium_port_get_resolution_rpc(chamelium, port_mapping->port_id, &screen_res_w, &screen_res_h);
+		igt_assert_eq(screen_res_w, modes[i].hdisplay);
+		igt_assert_eq(screen_res_h, modes[i].vdisplay);
+
+		igt_remove_fb(drm_fd, &fb);
+	}
+
+	igt_modeset_disable_all_outputs(&display);
+
+	igt_display_fini(&display);
+	drmModeFreeConnector(connector);
+}
+
 
 igt_main {
 	struct igt_chamelium_rpc *chamelium;
@@ -78,7 +162,7 @@ igt_main {
 	igt_fixture {
 		chamelium = chamelium_rpc_init_from_config();
 		igt_assert(chamelium);
-		drm_fd = drm_open_driver_master(DRIVER_ANY);
+		drm_fd = drm_open_driver(DRIVER_ANY);
 		igt_assert(drm_fd);
 		chamelium_rpc_fill_port_mapping(chamelium, drm_fd);
 	}
@@ -159,6 +243,23 @@ igt_main {
 		}
 	}
 
+	igt_describe("Set a basic EDID and check if resolution are correct");
+	igt_subtest_with_dynamic("edid-resolution-list") {
+		struct chamelium_rpc_port_mapping *port, *tmp;
+
+		igt_list_for_each_entry_safe(port, tmp, chamelium_rpc_get_port_mapping(chamelium), link) {
+			igt_dynamic_f("port-%d", port->port_id) {
+				char *name;
+
+				name = chamelium_get_port_name_rpc(chamelium, port->port_id);
+				igt_info("Testing port %s (%s)\n", port->connector_name, name);
+				free(name);
+
+				edid_resolution_list(drm_fd, chamelium, port);
+			}
+		}
+	}
+
 	igt_fixture {
 		chamelium_rpc_uninit(chamelium);
 		drm_close_driver(drm_fd);

-- 
2.43.2



More information about the igt-dev mailing list