[PATCH 1/2] lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format
Kamil Konieczny
kamil.konieczny at linux.intel.com
Fri Jun 7 12:31:15 UTC 2024
Hi Melanie,
On 2024-06-06 at 17:45:22 +0530, Melanie Lobo wrote:
one more nit about subject, you wrote:
lib/intel_aux_pgtable: Library to add support for RGB16161616_64B format
This should be:
lib/intel_aux_pgtable: Add RGB16161616_64B FP16 compressed format
you already have 'lib/' in begin of filename, no need to add
that later.
Juha-Pekka or Swati - fill free to suggest better subject, I do
not know specification of this new format.
Regards,
Kamil
> MTL supports RGB16161616_64B FP16 format which is a binary
> floating-point computer number format that occupies 16 bits
> in computer memory.
>
> This was tested with kernel patch,
> https://patchwork.freedesktop.org/series/124957/
> https://lore.kernel.org/all/20240605055819.9510-1-melanie.lobo@intel.com/
>
> cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> cc: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> cc: Swati Sharma <swati2.sharma at intel.com>
> Signed-off-by: Melanie Lobo <melanie.lobo at intel.com>
> ---
> lib/intel_aux_pgtable.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/intel_aux_pgtable.c b/lib/intel_aux_pgtable.c
> index 3cbb0e26f35c..87df50e71bbd 100644
> --- a/lib/intel_aux_pgtable.c
> +++ b/lib/intel_aux_pgtable.c
> @@ -22,6 +22,7 @@
> #define AUX_FORMAT_AYUV 0x09
> #define AUX_FORMAT_ARGB_8B 0x0A
> #define AUX_FORMAT_NV12_21 0x0F
> +#define AUX_FORMAT_RGBA16_FLOAT 0x1
>
> struct pgtable_level_desc {
> int idx_shift;
> @@ -306,6 +307,10 @@ static uint64_t pgt_get_l1_flags(const struct intel_buf *buf, int surface_idx)
> entry.e.format = AUX_FORMAT_ARGB_8B;
> entry.e.depth = bpp_to_depth_val(32);
> break;
> + case 64:
> + entry.e.format = AUX_FORMAT_RGBA16_FLOAT;
> + entry.e.depth = bpp_to_depth_val(64);
> + break;
> default:
> igt_assert(0);
> }
> --
> 2.17.1
>
More information about the igt-dev
mailing list