[PATCH i-g-t v3 1/2] lib/igt_chamelium: check drmModeGetConnector() before using
Kamil Konieczny
kamil.konieczny at linux.intel.com
Fri Jun 7 14:41:15 UTC 2024
Hi Luca,
On 2024-05-30 at 11:59:07 +0300, Luca Coelho wrote:
> The drmModeGetConnector() function can return NULL in some cases, so
> we need to check the return value before accessing it. This is not
> being checked in wait_for_connected_state(), so fix that.
>
> Cc: Mark Yacoub <markyacoub at chromium.org>
> Cc: Manasi Navare <navaremanasi at chromium.org>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> lib/igt_chamelium.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index 016d5356630c..620fbbf7d94f 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -524,6 +524,11 @@ static bool wait_for_connected_state(int drm_fd,
> drmModeConnector *connector =
> drmModeGetConnector(drm_fd, connectors[i]);
>
> + if (!connector) {
> + connected = false;
> + break;
> + }
> +
> connected = connector->connection == DRM_MODE_CONNECTED;
>
> drmModeFreeConnector(connector);
> --
> 2.39.2
>
More information about the igt-dev
mailing list