[PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible

[Cavitt, Jonathan]

-----Original Message-----
From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Vinod Govindapillai
Sent: Friday, June 7, 2024 7:58 AM
To: igt-dev at lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai at intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>
Subject: [PATCH i-g-t 3/4] tests/kms_dirtyfb: disable psr feature only if psr possible
> 
> When kms_dirtyfb tests are executed on cases where PSR is not
> possible the tests are getting skipped. This is because igt_skip
> is use in psr_set function. So avoid calling the psr_disable if
> not necessary.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>

Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> ---
>  tests/intel/kms_dirtyfb.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 6121599ec..2a32fab56 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -169,7 +169,10 @@ static void check_feature(data_t *data)
>  static void disable_features(data_t *data)
>  {
>  	intel_fbc_disable(data->drm_fd);
> -	psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +
> +	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
> +		psr_disable(data->drm_fd, data->debugfs_fd, NULL);
> +
>  	intel_drrs_disable(data->drm_fd, data->pipe);
>  }
>  
> -- 
> 2.34.1
> 
>