[PATCH i-g-t v2 4/5] tests/kms_dirtyfb: populate modeinfo before feature support check

[Cavitt, Jonathan]

-----Original Message-----
From: Govindapillai, Vinod <vinod.govindapillai at intel.com> 
Sent: Monday, June 10, 2024 5:00 AM
To: igt-dev at lists.freedesktop.org
Cc: Govindapillai, Vinod <vinod.govindapillai at intel.com>; Heikkila, Juha-pekka <juha-pekka.heikkila at intel.com>; Hogander, Jouni <jouni.hogander at intel.com>; Cavitt, Jonathan <jonathan.cavitt at intel.com>
Subject: [PATCH i-g-t v2 4/5] tests/kms_dirtyfb: populate modeinfo before feature support check
> 
> Drmmmodeinfo is required to identify if there are any FBC size
> restrictions applicable to identify FBC is supported for the
> required test. So update drmmodeinfo early for each vald output.

s/vald/valid
But otherwise:
Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
-Jonathan Cavitt

> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
> ---
>  tests/intel/kms_dirtyfb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> index 2a32fab56..c0eacda9b 100644
> --- a/tests/intel/kms_dirtyfb.c
> +++ b/tests/intel/kms_dirtyfb.c
> @@ -180,8 +180,6 @@ static void prepare(data_t *data)
>  {
>  	igt_plane_t *primary;
>  
> -	data->mode = igt_output_get_mode(data->output);
> -
>  	igt_output_set_pipe(data->output, data->pipe);
>  
>  	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
> @@ -328,6 +326,8 @@ igt_main
>  				for_each_valid_output_on_pipe(&data.display,
>  							      data.pipe,
>  							      data.output) {
> +					data.mode = igt_output_get_mode(data.output);
> +
>  					if (!check_support(&data))
>  						continue;
>  
> -- 
> 2.34.1
> 
>