[PATCH v2 i-g-t] tests/intel/xe_create: Don't assert on presi execution
Kamil Konieczny
kamil.konieczny at linux.intel.com
Mon Jun 10 16:39:51 UTC 2024
Hi Balasubramani,
On 2024-06-10 at 12:43:20 +0530, Balasubramani Vivekanandan wrote:
> create_execqueues subtest is testing the time required for creating
> execqueues along with testing the functionality.
> Presi environments are not for testing performance. We can't use the
> same time limit set for silicon on presi environments as presi would be
> slow.
> Therefore the time limit check is skipped while executing on simulation.
>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> tests/intel/xe_create.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
> index d41557c85..76ffdcef2 100644
> --- a/tests/intel/xe_create.c
> +++ b/tests/intel/xe_create.c
> @@ -238,9 +238,14 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed,
> }
>
> seconds = igt_seconds_elapsed(&tv);
> - igt_assert_f(seconds < real_timeout,
> - "Creating %d exec_queues tooks too long: %d [limit: %d]\n",
> - MAXEXECQUEUES, seconds, real_timeout);
> + if (seconds > real_timeout) {
> + if (igt_run_in_simulation())
> + igt_info("Creating %d exec_queues took too long: %d [limit: %d] seconds\n",
> + MAXEXECQUEUES, seconds, real_timeout);
> + else
> + igt_assert_f(false, "Creating %d exec_queues took too long: %d [limit: %d] seconds\n",
> + MAXEXECQUEUES, seconds, real_timeout);
> + }
> }
>
> /**
> --
> 2.25.1
>
More information about the igt-dev
mailing list