[PATCH i-g-t 7/8] tests/kms_universal_plane: Test cleanup

B, Jeevan jeevan.b at intel.com
Wed Jun 12 11:35:37 UTC 2024


LGTM. 

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, June 11, 2024 10:24 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [PATCH i-g-t 7/8] tests/kms_universal_plane: Test cleanup
> 
> Make sure the below points in IGT cleanup:
> 
>  - Sanitize the state before starting the subtest.
>  - Clear the states before exiting the subtest.
>  - Update existing libdrm APIs with IGT kms APIs.
>  - Other misc (Ex: update deprecated APIs/macros/enums, FB leaks etc..)
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_universal_plane.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c index
> a6e11777d..8c1ce8143 100644
> --- a/tests/kms_universal_plane.c
> +++ b/tests/kms_universal_plane.c
> @@ -139,7 +139,7 @@ functional_test_fini(functional_test_t *test,
> igt_output_t *output)
>  	igt_remove_fb(test->data->drm_fd, &test->red_fb);
>  	igt_remove_fb(test->data->drm_fd, &test->yellow_fb);
> 
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit2(&test->data->display, COMMIT_LEGACY);  }
> 
> @@ -386,7 +386,7 @@ sanity_test_fini(sanity_test_t *test, igt_output_t
> *output)
>  	igt_remove_fb(test->data->drm_fd, &test->undersized_fb);
>  	igt_remove_fb(test->data->drm_fd, &test->blue_fb);
> 
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit2(&test->data->display, COMMIT_LEGACY);  }
> 
> @@ -516,7 +516,7 @@ pageflip_test_fini(pageflip_test_t *test, igt_output_t
> *output)
>  	igt_remove_fb(test->data->drm_fd, &test->red_fb);
>  	igt_remove_fb(test->data->drm_fd, &test->blue_fb);
> 
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit2(&test->data->display, COMMIT_LEGACY);  }
> 
> @@ -603,7 +603,7 @@ cursor_leak_test_fini(data_t *data,
>  	for (i = 0; i < 10; i++)
>  		igt_remove_fb(data->drm_fd, &curs[i]);
> 
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  }
> 
>  static int
> @@ -752,7 +752,7 @@ gen9_test_fini(gen9_test_t *test, igt_output_t
> *output)
>  	igt_remove_fb(test->data->drm_fd, &test->smallred_fb);
>  	igt_remove_fb(test->data->drm_fd, &test->smallblue_fb);
> 
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit2(&test->data->display, COMMIT_LEGACY);  }
> 
> --
> 2.43.2



More information about the igt-dev mailing list