[PATCH i-g-t 1/8] tests/intel/kms_fence_pin_leak: Test cleanup

B, Jeevan jeevan.b at intel.com
Fri Jun 14 05:28:49 UTC 2024


LGTM. 

Reviewed-by: Jeevan B <jeevan.b at intel.com>

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Bhanuprakash Modem
> Sent: Tuesday, June 11, 2024 10:24 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [PATCH i-g-t 1/8] tests/intel/kms_fence_pin_leak: Test cleanup
> 
> Make sure the below points in IGT cleanup:
> 
>  - Sanitize the state before starting the subtest.
>  - Clear the states before exiting the subtest.
>  - Update existing libdrm APIs with IGT kms APIs.
>  - Other misc (Ex: update deprecated APIs/macros/enums, FB leaks etc..)
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/intel/kms_fence_pin_leak.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/intel/kms_fence_pin_leak.c b/tests/intel/kms_fence_pin_leak.c
> index 5d25d9ee3..8ccd73a93 100644
> --- a/tests/intel/kms_fence_pin_leak.c
> +++ b/tests/intel/kms_fence_pin_leak.c
> @@ -199,7 +199,7 @@ static void run_single_test(data_t *data, enum pipe pipe,
> igt_output_t *output)
>  	}
> 
>  	igt_plane_set_fb(primary, NULL);
> -	igt_output_set_pipe(output, PIPE_ANY);
> +	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_display_commit(display);
> 
>  	igt_remove_fb(data->drm_fd, &fb[1]);
> @@ -234,18 +234,17 @@ igt_simple_main
>  	data_t data = {};
> 
>  	data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> +	kmstest_set_vt_graphics_mode();
> +	igt_display_require(&data.display, data.drm_fd);
> +	igt_display_require_output(&data.display);
> +
>  	igt_require_gem(data.drm_fd);
>  	igt_require(gem_available_fences(data.drm_fd) > 0);
>  	igt_require(gem_has_contexts(data.drm_fd));
> 
>  	data.devid = intel_get_drm_devid(data.drm_fd);
> -
> -	kmstest_set_vt_graphics_mode();
> -
>  	data.bops = buf_ops_create(data.drm_fd);
> 
> -	igt_display_require(&data.display, data.drm_fd);
> -
>  	alloc_fence_objs(&data);
> 
>  	run_test(&data);
> --
> 2.43.2



More information about the igt-dev mailing list