[PATCH i-g-t] test/intel/xe_gt_freq: Remove act freq check from freq_low_max test

Riana Tauro riana.tauro at intel.com
Thu Jun 20 16:22:49 UTC 2024



On 6/20/2024 6:24 PM, Badal Nilawar wrote:
> First we check gt idle status and then check act freq. However, it’s
> important to note that there may be a race condition where the gt
> transitions to c6 before we complete the act freq check.
> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1045
> Fixes: 1a1e668e774e ("tests/intel/xe_gt_freq: Fix freq_low_max test")
> Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar at intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro at intel.com>
> ---
>   tests/intel/xe_gt_freq.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tests/intel/xe_gt_freq.c b/tests/intel/xe_gt_freq.c
> index d2e4d1a09..b3562181d 100644
> --- a/tests/intel/xe_gt_freq.c
> +++ b/tests/intel/xe_gt_freq.c
> @@ -277,9 +277,6 @@ static void test_freq_low_max(int fd, int gt_id)
>   	rpe = get_freq(fd, gt_id, "rpe");
>   
>   	igt_assert(get_freq(fd, gt_id, "cur") == rpe);
> -
> -	if (!xe_is_gt_in_c6(fd, gt_id))
> -		igt_assert(get_freq(fd, gt_id, "act") == rpe);
>   }
>   
>   /**


More information about the igt-dev mailing list