[PATCH i-g-t 1/5] tests/vmwgfx: Removing incorrect assert in mob_repeated_unref
Zack Rusin
zack.rusin at broadcom.com
Thu Jun 27 19:56:11 UTC 2024
From: Maaz Mombasawala <mombasawalam at vmware.com>
Remove an incorrect assert in test mob_repeated_unref that checked if return
value from multiple unrefs of a mob was 0. This was a bug in the vmwgfx driver,
since after the first unref it should return -EINVAL.
This bug was fixed with buffer rework in the vmwgfx driver and now the unref
ioctl behaves the correct way.
Signed-off-by: Maaz Mombasawala <mombasawalam at vmware.com>
Reviewed-by: Martin Krastev <krastevm at vmware.com>
Reviewed-by: Ian Forbes <iforbes at vmware.com>
Signed-off-by: Zack Rusin <zack.rusin at broadcom.com>
---
tests/vmwgfx/vmw_ref_count.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/vmwgfx/vmw_ref_count.c b/tests/vmwgfx/vmw_ref_count.c
index da4b41f89..92d49dbd0 100644
--- a/tests/vmwgfx/vmw_ref_count.c
+++ b/tests/vmwgfx/vmw_ref_count.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0 OR MIT
/**********************************************************
- * Copyright 2021-2022 VMware, Inc.
+ * Copyright 2021-2023 VMware, Inc.
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
@@ -256,13 +256,11 @@ igt_main
/* Shouldn't crash on multiple invocations */
for (i = 0; i < 3; i++) {
- int ret;
struct drm_vmw_handle_close_arg arg = {
.handle = mob->handle
};
- ret = drmCommandWrite(fd1, DRM_VMW_HANDLE_CLOSE, &arg,
+ drmCommandWrite(fd1, DRM_VMW_HANDLE_CLOSE, &arg,
sizeof(arg));
- igt_assert_eq(ret, 0);
}
free(mob);
}
--
2.40.1
More information about the igt-dev
mailing list