[PATCH i-g-t 4/5] tests/vmwgfx: Fix and extend the reference counting test

[Zack Rusin]

On Fri, Jun 28, 2024 at 12:13 PM Kamil Konieczny
<kamil.konieczny at linux.intel.com> wrote:
>
> Hi Zack,
> On 2024-06-27 at 15:56:14 -0400, Zack Rusin wrote:
> > Fix a few issues related to buffer managment in the reference counting
> > test. Extend it to include various prime related reference counting
> > issues.
> - ^^^^^^
> imho better 'capabilities' or some other word.
>
> >
> > Signed-off-by: Zack Rusin <zack.rusin at broadcom.com>
> > ---
> >  lib/igt_vmwgfx.c             |  45 +++-----
> >  lib/igt_vmwgfx.h             |  30 +----
> >  tests/vmwgfx/vmw_ref_count.c | 207 +++++++++++++++++++++++++++++------
> >  3 files changed, 193 insertions(+), 89 deletions(-)
> >
> > diff --git a/lib/igt_vmwgfx.c b/lib/igt_vmwgfx.c
> > index d2f699575..b62d7a326 100644
> > --- a/lib/igt_vmwgfx.c
> > +++ b/lib/igt_vmwgfx.c
> > @@ -1,28 +1,8 @@
> >  // SPDX-License-Identifier: GPL-2.0 OR MIT
> > -/**********************************************************
> > - * Copyright 2021-2023 VMware, Inc.
> ------------------------- ^^^^^^^^^^^^
>
> > - *
> > - * Permission is hereby granted, free of charge, to any person
> > - * obtaining a copy of this software and associated documentation
> > - * files (the "Software"), to deal in the Software without
> > - * restriction, including without limitation the rights to use, copy,
> > - * modify, merge, publish, distribute, sublicense, and/or sell copies
> > - * of the Software, and to permit persons to whom the Software is
> > - * furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice shall be
> > - * included in all copies or substantial portions of the Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> > - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> > - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> > - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > - * SOFTWARE.
> > - *
> > - **********************************************************/
> > +/*
> > + * Copyright (c) 2021-2024 Broadcom. All Rights Reserved. The term
> ----------------------------- ^^^^^^^^^
>
> This is not the same. Btw why not:
>
>  * Copyright 2021-2023 VMware, Inc.
>  * Copyright 2024 Broadcom, Inc. and/or its subsidiaries.
>
> But I am a little reluctant to see '... subsidiaries' as this
> adds some unknown numbers/names here?
> +cc Petri

Unfortunately, this is just the way it is. Broadcom has acquired
VMware and its IP. Unless Intel's legal team's official position is
that Broadcom's legal team got it wrong, then that's the copyright
header we have to use.

> > @@ -1,28 +1,8 @@
> >  /* SPDX-License-Identifier: GPL-2.0 OR MIT */
> > -/**********************************************************
> > - * Copyright 2021-2023 VMware, Inc.
> ------------------------- ^
> Same here, you replaced VMware with Broadcom.

Yea, that's correct.

z