[PATCH i-g-t 13/28] tests/intel/xe_oa: Add oa exponent tests

Dixit, Ashutosh ashutosh.dixit at intel.com
Sun Jun 30 22:43:11 UTC 2024


On Thu, 20 Jun 2024 16:18:30 -0700, Umesh Nerlige Ramappa wrote:
>
> On Thu, Jun 20, 2024 at 01:00:38PM -0700, Ashutosh Dixit wrote:
> > Add "invalid-oa-exponent" and "oa-exponents".
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
>
> one nit. with or without
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Thanks.

> > +static bool expected_report_timing_delta(uint32_t delta, uint32_t expected_delta)
> > +{
> > +	/*
> > +	 * On ICL, the OA unit appears to be a bit more relaxed about
> > +	 * its timing for emitting OA reports (often missing the
> > +	 * deadline by 1 timestamp).
> > +	 */
> > +	if (IS_ICELAKE(devid))
> > +		return delta <= (expected_delta + 3);
> > +	else
>
> can drop ICL stuff

Done.

Thanks.
--
Ashutosh


More information about the igt-dev mailing list