[PATCH i-g-t 1/5] lib/rendercopy_gen9: use MOCS index helper

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Mon Mar 4 10:10:24 UTC 2024


On Fri, Mar 01, 2024 at 05:16:14PM +0000, Matthew Auld wrote:
> UC looks to be the sensible default here, since it will work with
> display engine if rendering onto scanout surface. Use the matching
> helper.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> ---
>  lib/rendercopy_gen9.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
> index efd7cb37c..404406e5f 100644
> --- a/lib/rendercopy_gen9.c
> +++ b/lib/rendercopy_gen9.c
> @@ -180,10 +180,7 @@ gen9_bind_buf(struct intel_bb *ibb, const struct intel_buf *buf, int is_dst,
>  	ss->ss0.horizontal_alignment = 1; /* align 4 or HALIGN_32 on display ver >= 13*/
>  
>  	if (HAS_4TILE(ibb->devid)) {
> -		/*
> -		 * mocs table version 1 index 3 groub wb use l3
> -		 */
> -		ss->ss1.mocs_index = 3;
> +		ss->ss1.mocs_index = intel_get_uc_mocs_index(i915);
>  		ss->ss5.mip_tail_start_lod = 0;
>  	} else {
>  		ss->ss0.render_cache_read_write = 1;
> -- 
> 2.43.2
> 

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list