[PATCH i-g-t 2/2] igt: Remove duplicate igt_display_require() calls

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Mar 4 16:23:09 UTC 2024


Hi Arthur,
On 2024-02-15 at 16:21:05 -0300, Arthur Grillo wrote:
> Now that we don't need call igt_display_require() twice, remove the
> duplicate calls, previously needed to expose the writeback output.
> 
> Signed-off-by: Arthur Grillo <arthurgrillo at riseup.net>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  benchmarks/kms_fb_stress.c | 2 --
>  tests/kms_writeback.c      | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/benchmarks/kms_fb_stress.c b/benchmarks/kms_fb_stress.c
> index 9a0e98bed8ad..00eaa0a4931a 100644
> --- a/benchmarks/kms_fb_stress.c
> +++ b/benchmarks/kms_fb_stress.c
> @@ -150,8 +150,6 @@ igt_simple_main
>  
>  	data.fd = drm_open_driver_master(DRIVER_ANY);
>  
> -	igt_display_require(&data.display, data.fd);
> -
>  	kmstest_set_vt_graphics_mode();
>  
>  	igt_display_require(&data.display, data.fd);
> diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
> index cda13b850dfb..6cd685b37af2 100644
> --- a/tests/kms_writeback.c
> +++ b/tests/kms_writeback.c
> @@ -563,7 +563,6 @@ igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
>  
>  	igt_fixture {
>  		display.drm_fd = drm_open_driver_master(DRIVER_ANY);
> -		igt_display_require(&display, display.drm_fd);
>  
>  		kmstest_set_vt_graphics_mode();
>  
> 
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list