[PATCH i-g-t 03/24] tests/intel: Introduce Fences subcategory

Piecielska, Katarzyna katarzyna.piecielska at intel.com
Wed Mar 6 09:58:29 UTC 2024


> Let's introduce 'Fences' subcategory to allow better alignment between 
> i915 and XE.
> 

You added already a bucket at Functionality level also called "fences".

While this works fine for igt_doc tools, it is confusing for people to have the same name meaning different things. Also, some Intel CI tools don't allow two buckets with the same name. So, please either change the term on patch 2 or here.

Regards,
Mauro

[Katarzyna] You're right 😊 I will keep 'fences' as functionality and find other subcategories for those tests.
BTW there is one tests that was added to this commit by mistake - tests/intel/gem_vm_create.c - belongs to contexts

Kasia
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> ---
>  tests/intel/gem_fence_thrash.c       |  3 +++
>  tests/intel/gem_fence_upload.c       |  3 +++
>  tests/intel/gem_fenced_exec_thrash.c |  3 +++
>  tests/intel/gem_vm_create.c          | 10 ++++------
>  tests/intel/prime_busy.c             |  2 +-
>  5 files changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/intel/gem_fence_thrash.c 
> b/tests/intel/gem_fence_thrash.c index 4cb3d842b..0c9be92df 100644
> --- a/tests/intel/gem_fence_thrash.c
> +++ b/tests/intel/gem_fence_thrash.c
> @@ -46,6 +46,9 @@
>  /**
>   * TEST: gem fence thrash
>   * Feature: gtt, synchronization
> + * Sub-category: Fences
> + * Category: Desktop client
> + * Functionality: synchronization
>   * Run type: FULL
>   *
>   * SUBTEST: bo-copy
> diff --git a/tests/intel/gem_fence_upload.c 
> b/tests/intel/gem_fence_upload.c index b239c0e78..074908d81 100644
> --- a/tests/intel/gem_fence_upload.c
> +++ b/tests/intel/gem_fence_upload.c
> @@ -43,6 +43,9 @@
>  #include "i915/gem_create.h"
>  /**
>   * TEST: gem fence upload
> + * Sub-category: Fences
> + * Category: Desktop client
> + * Functionality: synchronization
>   * Run type: FULL
>   *
>   * SUBTEST: performance
> diff --git a/tests/intel/gem_fenced_exec_thrash.c 
> b/tests/intel/gem_fenced_exec_thrash.c
> index 098f22ef4..b26eb7780 100644
> --- a/tests/intel/gem_fenced_exec_thrash.c
> +++ b/tests/intel/gem_fenced_exec_thrash.c
> @@ -37,6 +37,9 @@
>   * TEST: gem fenced exec thrash
>   * Description: Test execbuf fence accounting.
>   * Feature: gtt, synchronization
> + * Sub-category: Fences
> + * Category: Desktop client
> + * Functionality: synchronization
>   * Run type: FULL
>   *
>   * SUBTEST: 2-spare-fences
> diff --git a/tests/intel/gem_vm_create.c b/tests/intel/gem_vm_create.c 
> index 8834c987f..d3d03eb73 100644
> --- a/tests/intel/gem_vm_create.c
> +++ b/tests/intel/gem_vm_create.c
> @@ -30,22 +30,20 @@
>  /**
>   * TEST: gem vm create
>   * Category: Server
> - * Functionality: context management
> - * Run type: FULL
> - * Sub-category: Compute
> + * Functionality: compute
> + * Sub-category: Context
> + * Feature: mapping
>   * Test category: GEM_Legacy
> + * Run type: FULL
>   *
>   * SUBTEST: create-ext
> - * Feature: mapping
>   *
>   * SUBTEST: execbuf
>   * Feature: cmd_submission, mapping
>   *
>   * SUBTEST: invalid-create
> - * Feature: mapping
>   *
>   * SUBTEST: invalid-destroy
> - * Feature: mapping
>   *
>   * SUBTEST: isolation
>   * Feature: context, mapping
> diff --git a/tests/intel/prime_busy.c b/tests/intel/prime_busy.c index 
> 90d79864f..a4edb0e0a 100644
> --- a/tests/intel/prime_busy.c
> +++ b/tests/intel/prime_busy.c
> @@ -33,7 +33,7 @@
>   * Feature: prime
>   * Functionality: buffer management
>   * Run type: FULL
> - * Sub-category: DRM
> + * Sub-category: Fences
>   * Test category: GEM_Legacy
>   *
>   * SUBTEST: after


More information about the igt-dev mailing list