[PATCH i-g-t 10/24] tests/intel: Introduce Flat-ccs subcategory

Mauro Carvalho Chehab mauro.chehab at linux.intel.com
Thu Mar 7 12:56:51 UTC 2024


On Thu, 7 Mar 2024 09:50:02 +0000
"Piecielska, Katarzyna" <katarzyna.piecielska at intel.com> wrote:

> > Let's introduce flat-ccs subcategory.
> > 
> > Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> > Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > ---
> >  tests/intel/gem_ccs.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/intel/gem_ccs.c b/tests/intel/gem_ccs.c index 
> > 3442ecfd3..e6257aeac 100644
> > --- a/tests/intel/gem_ccs.c
> > +++ b/tests/intel/gem_ccs.c
> > @@ -20,6 +20,9 @@
> >   * TEST: gem ccs
> >   * Description: Exercise gen12 blitter with and without flatccs compression
> >   * Feature: flat_ccs_mapping
> > + * Sub-category: Flat-ccs
> > + * Category: Desktop \ Server
> > + * Functionality: block-copy  
> 
> LGTM.
> 
> A minor nitpick: on some places like "Desktop \ Server" you're using the left/reverse backslash, while on others, you're using the right one. 
> 
> I would standardize it to always use "/".

> > Looking at i915 for DII I see only 'Desktop \ Server'. If we want to standardize that - let's do that in separate commit.

Yeah, sure. 

Regards,
Mauro


More information about the igt-dev mailing list