[PATCH i-g-t] lib/igt_kmod: Allow to load kunit from alias

Lucas De Marchi lucas.demarchi at intel.com
Fri Mar 8 19:33:13 UTC 2024


On Tue, Mar 05, 2024 at 06:31:10PM +0100, Kamil Konieczny wrote:
>Hi Lucas,
>On 2024-03-05 at 08:23:28 -0600, Lucas De Marchi wrote:
>> On Mon, Mar 04, 2024 at 05:05:29PM +0100, Kamil Konieczny wrote:
>> > Hi Lucas,
>> > On 2024-02-22 at 11:30:44 -0800, Lucas De Marchi wrote:
>> > > Instead of only allowing to load the from the module name, also allow it
>> > > from alias by using kmod_module_new_from_lookup(). With that a user can
>> > > have their on aliases and the kernel can also export a compat alias for
>> > > future module renames.
>> > >
>> > > Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> >
>> > It is somehow test listing failing: ./dmabuf --list
>> >
>> > tests/dmabuf:
>> > Checking invalid option handling...
>> > Checking valid option handling...
>> > Checking subtest enumeration...
>> > test does seem to be using igt_main() (should have subtests) and yet --list-subtests is empty!
>> > FAIL: tests/dmabuf
>>
>> how did you find what was the test failing?  The new version is still
>> failing, although dmabuf --list does return the same as before.
>>
>> thanks
>> Lucas De Marchi
>
>This was just:
>meson test -C build
>
>but your v2 now build ok on my local machine.
>
>From error build link:
>https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/55851077/raw
>
>I guess it is failing on:
>
>Warning: Documented igt at dmabuf@all-tests doesn't exist on source files
>Warning: Documented igt at i915_selftest@live doesn't exist on source files
>Warning: Documented igt at i915_selftest@mock doesn't exist on source files
>Warning: Documented igt at i915_selftest@perf doesn't exist on source files
>  ninja: build stopped: subcommand failed.
>
>I do see new CI script there which I cannot find locally:
>
>[1154/1787] Generating i915_selftest.testlist with a meson_exe.py custom command.


problem was a bug in libkmod that was fixed a couple years ago.
Apparently the fix didn't propagate to Debian. Fortunately the
workaround is easy. Just submitted a v3.


thanks
Lucas De Marchi


>
>Mauro could you help spotting what is a problem here?
>
>Regards,
>Kamil
>


More information about the igt-dev mailing list