[PATCH i-g-t, v5 1/2] drm-uapi/xe: Add test to query GuC firmware submission version
Francois Dugast
francois.dugast at intel.com
Mon Mar 11 16:23:35 UTC 2024
This aligns with kernel commit ("drm/xe: Add uAPI to query GuC firmware
submission version").
v2: Print branch first, use memset to zero the query (John Harrison)
v3: Update header to match the KMD version with branch first (John Harrison)
v4: Add lore link to corresponding kernel commit (Francois Dugast)
Cc: John Harrison <John.C.Harrison at Intel.com>
Cc: José Roberto de Souza <jose.souza at intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Signed-off-by: Francois Dugast <francois.dugast at intel.com>
Link: https://lore.kernel.org/intel-xe/20240208183539.185095-1-jose.souza@intel.com/
Reviewed-by: José Roberto de Souza <jose.souza at intel.com>
---
tests/intel/xe_query.c | 92 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c
index 5807fe3ed..d0cc89092 100644
--- a/tests/intel/xe_query.c
+++ b/tests/intel/xe_query.c
@@ -741,6 +741,96 @@ static void test_engine_cycles_invalid(int fd)
query_engine_cycles(fd, &ts);
}
+/**
+ * SUBTEST: query-uc-fw-version-guc
+ * Test category: functionality test
+ * Description: Display the GuC firmware submission version
+ *
+ * SUBTEST: multigpu-query-uc-fw-version-guc
+ * Test category: functionality test
+ * Sub-category: MultiGPU
+ * Description: Display GuC firmware submission version for all Xe devices.
+ */
+static void
+test_query_uc_fw_version_guc(int fd)
+{
+ struct drm_xe_query_uc_fw_version *uc_fw_version;
+ struct drm_xe_device_query query = {
+ .extensions = 0,
+ .query = DRM_XE_DEVICE_QUERY_UC_FW_VERSION,
+ .size = 0,
+ .data = 0,
+ };
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
+
+ uc_fw_version = malloc(query.size);
+ igt_assert(uc_fw_version);
+
+ memset(uc_fw_version, 0, sizeof(*uc_fw_version));
+ uc_fw_version->uc_type = XE_QUERY_UC_TYPE_GUC_SUBMISSION;
+ query.data = to_user_pointer(uc_fw_version);
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
+ igt_info("XE_QUERY_UC_TYPE_GUC_SUBMISSION %u.%u.%u.%u\n",
+ uc_fw_version->branch_ver,
+ uc_fw_version->major_ver,
+ uc_fw_version->minor_ver,
+ uc_fw_version->patch_ver);
+ igt_assert(uc_fw_version->major_ver > 0 || uc_fw_version->minor_ver > 0);
+
+ free(uc_fw_version);
+}
+
+/**
+ * SUBTEST: query-invalid-uc-fw-version-mbz
+ * Test category: functionality test
+ * Description: Check query with invalid arguments returns expected error code.
+ *
+ * SUBTEST: multigpu-query-invalid-uc-fw-version-mbz
+ * Test category: functionality test
+ * Sub-category: MultiGPU
+ * Description: Check query with invalid arguments for all Xe devices.
+ */
+static void
+test_query_uc_fw_version_invalid_mbz(int fd)
+{
+ struct drm_xe_query_uc_fw_version *uc_fw_version;
+ struct drm_xe_device_query query = {
+ .extensions = 0,
+ .query = DRM_XE_DEVICE_QUERY_UC_FW_VERSION,
+ .size = 0,
+ .data = 0,
+ };
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
+
+ uc_fw_version = malloc(query.size);
+ igt_assert(uc_fw_version);
+
+ memset(uc_fw_version, 0, sizeof(*uc_fw_version));
+ uc_fw_version->uc_type = XE_QUERY_UC_TYPE_GUC_SUBMISSION;
+ query.data = to_user_pointer(uc_fw_version);
+
+ /* Make sure the baseline passes */
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0);
+
+ /* Make sure KMD rejects non-zero padding/reserved fields */
+ uc_fw_version->pad = -1;
+ do_ioctl_err(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query, EINVAL);
+ uc_fw_version->pad = 0;
+
+ uc_fw_version->pad2 = -1;
+ do_ioctl_err(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query, EINVAL);
+ uc_fw_version->pad2 = 0;
+
+ uc_fw_version->reserved = -1;
+ do_ioctl_err(fd, DRM_IOCTL_XE_DEVICE_QUERY, &query, EINVAL);
+ uc_fw_version->reserved = 0;
+
+ free(uc_fw_version);
+}
+
igt_main
{
const struct {
@@ -754,10 +844,12 @@ igt_main
{ "query-hwconfig", test_query_hwconfig },
{ "query-topology", test_query_gt_topology },
{ "query-cs-cycles", test_query_engine_cycles },
+ { "query-uc-fw-version-guc", test_query_uc_fw_version_guc },
{ "query-invalid-cs-cycles", test_engine_cycles_invalid },
{ "query-invalid-query", test_query_invalid_query },
{ "query-invalid-size", test_query_invalid_size },
{ "query-invalid-extension", test_query_invalid_extension },
+ { "query-invalid-uc-fw-version-mbz", test_query_uc_fw_version_invalid_mbz },
{ }
}, *f;
int xe, gpu_count;
--
2.34.1
More information about the igt-dev
mailing list