[PATCH i-g-t v3 14/25] tests/intel: Introduce Obsolete subcategory

[Kamil Konieczny]

Hi Katarzyna,
On 2024-03-12 at 14:14:08 +0000, Katarzyna Piecielska wrote:
> gen3_* tests are obsolete, so let's put them into one subcategory.
> 
> v2: change functionality to 'obsolete_test' to not break automation
> tools
> v3: Category and Sub-category need to be unique as well, so change
> Sub-category s/Obsolete/Obsolete_gen3/.
> 

Looks good, see two nits below.

> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/intel/gen3_mixed_blits.c         | 3 +++
>  tests/intel/gen3_render_linear_blits.c | 3 +++
>  tests/intel/gen3_render_mixed_blits.c  | 3 +++
>  tests/intel/gen3_render_tiledx_blits.c | 5 ++++-
>  tests/intel/gen3_render_tiledy_blits.c | 5 ++++-
>  5 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/gen3_mixed_blits.c b/tests/intel/gen3_mixed_blits.c
> index 3c6fb141a..2bb5517c8 100644
> --- a/tests/intel/gen3_mixed_blits.c
> +++ b/tests/intel/gen3_mixed_blits.c
> @@ -51,6 +51,9 @@
>  /**
>   * TEST: gen3 mixed blits
>   * Feature: obsolete
> + * Sub-category: Obsolete_gen3
> + * Functionality: obsolete_test
> + * Category: Obsolete
>   * Run type: FULL
>   *
>   * SUBTEST:
> diff --git a/tests/intel/gen3_render_linear_blits.c b/tests/intel/gen3_render_linear_blits.c
> index 7dfb2709a..681d7b01b 100644
> --- a/tests/intel/gen3_render_linear_blits.c
> +++ b/tests/intel/gen3_render_linear_blits.c
> @@ -50,6 +50,9 @@
>  /**
>   * TEST: gen3 render linear blits
>   * Feature: obsolete
> + * Sub-category: Obsolete_gen3
> + * Functionality: obsolete_test
> + * Category: Obsolete
>   * Run type: FULL
>   *
>   * SUBTEST:
> diff --git a/tests/intel/gen3_render_mixed_blits.c b/tests/intel/gen3_render_mixed_blits.c
> index f8e1bdfbd..ee42f068b 100644
> --- a/tests/intel/gen3_render_mixed_blits.c
> +++ b/tests/intel/gen3_render_mixed_blits.c
> @@ -51,6 +51,9 @@
>  /**
>   * TEST: gen3 render mixed blits
>   * Feature: obsolete
> + * Sub-category: Obsolete_gen3
> + * Functionality: obsolete_test
> + * Category: Obsolete
>   * Run type: FULL
>   *
>   * SUBTEST:
> diff --git a/tests/intel/gen3_render_tiledx_blits.c b/tests/intel/gen3_render_tiledx_blits.c
> index 1abe5adbc..ca49576a9 100644
> --- a/tests/intel/gen3_render_tiledx_blits.c
> +++ b/tests/intel/gen3_render_tiledx_blits.c
> @@ -25,7 +25,7 @@
>   *
>   */
>  
> -/** @file gen3_linear_render_blits.c
> +/** @file gen3_render_tiledx_blits.c

Please write about this correction in commit description.

>   *
>   * This is a test of doing many blits, with a working set
>   * larger than the aperture size.
> @@ -51,6 +51,9 @@
>  /**
>   * TEST: gen3 render tiledx blits
>   * Feature: obsolete
> + * Sub-category: Obsolete_gen3
> + * Category: Obsolete
> + * Functionality: obsolete_test
>   * Run type: FULL
>   *
>   * SUBTEST:
> diff --git a/tests/intel/gen3_render_tiledy_blits.c b/tests/intel/gen3_render_tiledy_blits.c
> index b1f4b628a..dfd3ef947 100644
> --- a/tests/intel/gen3_render_tiledy_blits.c
> +++ b/tests/intel/gen3_render_tiledy_blits.c
> @@ -25,7 +25,7 @@
>   *
>   */
>  
> -/** @file gen3_linear_render_blits.c
> +/** @file gen3_render_tiledy_blits.c

This also needs to be mensioned in description.
With this:

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

>   *
>   * This is a test of doing many blits, with a working set
>   * larger than the aperture size.
> @@ -51,6 +51,9 @@
>  /**
>   * TEST: gen3 render tiledy blits
>   * Feature: obsolete
> + * Sub-category: Obsolete_gen3
> + * Category: Obsolete
> + * Functionality: obsolete_test
>   * Run type: FULL
>   *
>   * SUBTEST:
> -- 
> 2.34.1
>