[PATCH i-g-t] tests/intel/xe_evict: Skip test if smem less than lmem

Matthew Brost matthew.brost at intel.com
Wed Mar 13 04:03:01 UTC 2024


On Tue, Mar 12, 2024 at 12:45:02PM +0530, priyanka.dandamudi at intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Currently the tests are failing with OOO memory error.
> Added code to skip the test if the system memory size is less than local
> memory size.
> 
> Cc: Matthew Brost <matthew.brost at intel.com>
> Cc: Venkata Ramana Nayana <venkata.ramana.nayana at intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/intel/xe_evict.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/xe_evict.c b/tests/intel/xe_evict.c
> index 4de82c3bd..2dc3fe542 100644
> --- a/tests/intel/xe_evict.c
> +++ b/tests/intel/xe_evict.c
> @@ -753,6 +753,8 @@ igt_main
>  		igt_require(xe_has_vram(fd));
>  		vram_size = xe_visible_vram_size(fd, 0);
>  		igt_assert(vram_size);

I'd add a comment here explaining why we are skipping.

Test requires SRAM to about as big as VRAM. For example, small-cm creates
(448 / 2) BOs with a size (1 / 128) of the total VRAM size. For
simplicity ensure the SRAM size >= VRAM before running this test.

Matt

> +		igt_skip_on_f(igt_get_avail_ram_mb() < (vram_size >> 20),
> +			      "System memory is less than local memory \n");
>  
>  		xe_for_each_engine(fd, hwe)
>  			if (hwe->engine_class != DRM_XE_ENGINE_CLASS_COPY)
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list