[PATCH i-g-t 07/10] scripts/xls_to_doc.py: don't duplicate a common field

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Mar 14 15:34:12 UTC 2024


Hi Mauro,
On 2024-03-14 at 11:29:16 +0100, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> If the TEST field has the same value of the subtest one, ignore
> it when updating it, as the subtest on is inherited.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/xls_to_doc.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/xls_to_doc.py b/scripts/xls_to_doc.py
> index 749666faf41f..0d6ad0e0b1cd 100755
> --- a/scripts/xls_to_doc.py
> +++ b/scripts/xls_to_doc.py
> @@ -317,6 +317,11 @@ class FillTests(TestList):
>                              print(f"{testname}@{subtest} field {field}: Value unchanged: {value}. Ignoring it")
>                          continue
>  
> +                    if value == self.doc[test_nr].get(field, ""):
> +                        if self.verbose:
> +                            print(f"{testname}@{subtest} field {field}: Value matches common field. Ignoring it")
> +                            continue
> +
>                      if self.verbose > 0:
>                          print(f"Update {testname}@{subtest} field {field} on line {line}:")
>                          print(f"  Change from {doc_value} to {value}")
> -- 
> 2.43.2
> 


More information about the igt-dev mailing list