[PATCH i-g-t v2 0/4] New rotation test

Modem, Bhanuprakash bhanuprakash.modem at intel.com
Mon Mar 18 08:26:49 UTC 2024


On 13-03-2024 10:39 pm, Louis Chauvet wrote:
> The actual kms_rotation_crc test does not test all the rotation with all
> the formats. Create the test kms_rotation, which only test "full plane
> rotation", but for all the formats, plane and rotations configuration.

Why do we need a new test binary 'kms_rotation'?

IMHO, you could extend kms_rotation_crc to support other combinations.

- Bhanu

> 
> This new test allows to detect issues in [1], where the YUV rotation is
> faulty for reflect_x and reflect_y cases.
> 
> [1]: https://lore.kernel.org/dri-devel/20240304-yuv-v4-11-76beac8e9793@bootlin.com/
> 
> To: igt-dev at lists.freedesktop.org
> Cc: miquel.raynal at bootlin.com
> Cc: jeremie.dautheribes at bootlin.com
> Cc: thomas.petazzoni at bootlin.com
> Cc: arthurgrillo at riseup.net
> 
> Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
> ---
> Changes in v2:
> - Fix a typo in documentation
> - Fix a bug when using subsampling with non compatible sizes
> - Fix a bug I found when using different color count.
> - Add cli options to set specific plane size
> - Link to v1: https://lore.kernel.org/r/20240312-new_rotation-v1-0-ed9fe82589df@bootlin.com
> 
> ---
> Louis Chauvet (4):
>        lib/igt_kms: Add reflection name and mask
>        lib/igt_fb: Expose lookup_drm_format to access format properties in tests
>        tests/kms_rotation: Add extensive rotation test
>        tests/kms_rotation: Add command line option to reduce the number of tests
> 
>   lib/igt_fb.c         |  15 +-
>   lib/igt_fb.h         |  29 +++
>   lib/igt_kms.c        |  23 +++
>   lib/igt_kms.h        |   3 +
>   tests/kms_rotation.c | 550 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   tests/meson.build    |   1 +
>   6 files changed, 608 insertions(+), 13 deletions(-)
> ---
> base-commit: a44ebfe43edc96acab22a19b6a8850eef9202eea
> change-id: 20240312-new_rotation-c034a68b3b9d
> 
> Best regards,


More information about the igt-dev mailing list