[PATCH i-g-t v4 08/25] tests/intel: Introduce Blitter subcategory

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Tue Mar 19 12:40:25 UTC 2024


On Thu, Mar 14, 2024 at 02:34:38PM +0000, Katarzyna Piecielska wrote:
> Let's introduce Blitter subcategory.
> 
> v2: introduce more granularity in Blitter subcategory to not break
> automation:
>  - igt at gem_exercise_blt@fast-copy* - s/blitter/fast-copy/
>  - igt at gem_linear_blits@ - s/blitter/linear blit/
> 
> v2: Make Sub-category/Functionality/Feature unique values. (Kamil)
> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Karolina Stolarek <karolina.stolarek at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> ---
>  tests/intel/gem_exercise_blt.c      | 16 ++++++++--------
>  tests/intel/gem_linear_blits.c      |  6 +++---
>  tests/intel/gem_set_tiling_vs_blt.c |  3 +++
>  tests/intel/gen9_exec_parse.c       |  3 +++
>  4 files changed, 17 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/intel/gem_exercise_blt.c b/tests/intel/gem_exercise_blt.c
> index 4a9bc3729..39bbdda17 100644
> --- a/tests/intel/gem_exercise_blt.c
> +++ b/tests/intel/gem_exercise_blt.c
> @@ -13,19 +13,19 @@
>  /**
>   * TEST: gem exercise blt
>   * Description: Exercise blitter commands
> - * Feature: blitter
> - * Run type: FULL
> + * Feature: blitter feature
> + * Sub-category: Blitter
> + * Category: Desktop client
> + * Functionality: fast-copy
>   * Test category: GEM_Legacy
> + * Run type: FULL
>   *
>   * SUBTEST: fast-copy
> - * Description:
> - *   Check fast-copy blit
> - *   blitter
> + * Description: Check fast-copy blit blitter
>   *
>   * SUBTEST: fast-copy-emit
> - * Description:
> - *   Check multiple fast-copy in one batch
> - *   blitter
> + * Description: Check multiple fast-copy in one batch blitter
> + *
>   */
>  
>  IGT_TEST_DESCRIPTION("Exercise blitter commands");
> diff --git a/tests/intel/gem_linear_blits.c b/tests/intel/gem_linear_blits.c
> index 64f220cb3..aac84211f 100644
> --- a/tests/intel/gem_linear_blits.c
> +++ b/tests/intel/gem_linear_blits.c
> @@ -53,9 +53,9 @@
>   * TEST: gem linear blits
>   * Category: Infrastructure
>   * Description: Test doing many blits with a working set larger than the aperture size.
> - * Feature: blitter
> - * Functionality: blitter
> - * Sub-category: CMD submission
> + * Feature: blitter feature
> + * Functionality: linear blits
> + * Sub-category: Blitter
>   * Test category: GEM_Legacy
>   * Run type: FULL
>   *
> diff --git a/tests/intel/gem_set_tiling_vs_blt.c b/tests/intel/gem_set_tiling_vs_blt.c
> index 9077e0f3f..28469f5f3 100644
> --- a/tests/intel/gem_set_tiling_vs_blt.c
> +++ b/tests/intel/gem_set_tiling_vs_blt.c
> @@ -61,6 +61,9 @@
>   * TEST: gem set tiling vs blt
>   * Description: Check for proper synchronization of tiling changes vs. tiled gpu access.
>   * Feature: blitter, gtt
> + * Functionality: tiling
> + * Sub-category: Blitter
> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: tiled-to-tiled
> diff --git a/tests/intel/gen9_exec_parse.c b/tests/intel/gen9_exec_parse.c
> index 33ff6bcb5..509a2e80f 100644
> --- a/tests/intel/gen9_exec_parse.c
> +++ b/tests/intel/gen9_exec_parse.c
> @@ -36,6 +36,9 @@
>  /**
>   * TEST: gen9 exec parse
>   * Feature: blitter, command_parser
> + * Sub-category: Blitter
> + * Functionality: command_parser

I guess _ is not necessary here, with this nit fixed:

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: allowed-all
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list