[PATCH i-g-t v4 11/25] tests/intel: Introduce Firmware subcategory
Kamil Konieczny
kamil.konieczny at linux.intel.com
Tue Mar 19 17:17:12 UTC 2024
Hi Katarzyna,
On 2024-03-14 at 14:34:41 +0000, Katarzyna Piecielska wrote:
> Let's put huc & guc tests under Firmware subcategory.
>
> v2: Let's introduce Firmware subcategory and put there GUC and HUC related
> tests.
> v3: Make Sub-category/Functionality/Feature unique values. (Kamil)
>
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Chris Wilson <chris.p.wilson at intel.com>
> Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Feng Qi <feng.qi at intel.com>
> Cc: Tony Ye <tony.ye at intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> tests/intel/gem_huc_copy.c | 5 ++++-
> tests/intel/i915_selftest.c | 12 ++++++++----
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel/gem_huc_copy.c b/tests/intel/gem_huc_copy.c
> index 246fa0a8b..bacc03966 100644
> --- a/tests/intel/gem_huc_copy.c
> +++ b/tests/intel/gem_huc_copy.c
> @@ -38,7 +38,10 @@
> /**
> * TEST: gem huc copy
> * Description: A very simple workload for the HuC.
> - * Feature: huc
> + * Feature: firmware feature
> + * Sub-category: Firmware
> + * Category: Desktop client
> + * Functionality: HUC
Why not "HuC copy"?
In tests/, run: grep -ri ": huc" *
intel/xe_huc_copy.c: * Sub-category: HuC
intel/xe_huc_copy.c: * Functionality: HuC copy
intel/xe_huc_copy.c: * SUBTEST: huc_copy
intel/gem_huc_copy.c: * Functionality: HUC
intel/gem_huc_copy.c: * SUBTEST: huc-copy
Regards,
Kamil
> * Run type: BAT
> *
> * SUBTEST: huc-copy
> diff --git a/tests/intel/i915_selftest.c b/tests/intel/i915_selftest.c
> index bb0e844e9..2c5f6bce2 100644
> --- a/tests/intel/i915_selftest.c
> +++ b/tests/intel/i915_selftest.c
> @@ -192,25 +192,29 @@
> * SUBTEST: live at guc
> * Category: Selftest
> * Feature: GuC
> - * Functionality: Guc specific selftests
> + * Sub-category: Firmware
> + * Functionality: GUC
> * Test category: GuC
> *
> * SUBTEST: live at guc_doorbells
> * Category: Selftest
> * Feature: GuC
> - * Functionality: Guc specific selftests
> + * Sub-category: Firmware
> + * Functionality: GUC
> * Test category: GuC
> *
> * SUBTEST: live at guc_hang
> * Category: Selftest
> * Feature: GuC
> - * Functionality: Guc specific selftests
> + * Sub-category: Firmware
> + * Functionality: GUC
> * Test category: GuC
> *
> * SUBTEST: live at guc_multi_lrc
> * Category: Selftest
> * Feature: GuC
> - * Functionality: Guc specific selftests
> + * Sub-category: Firmware
> + * Functionality: GUC
> * Test category: GuC
> *
> * SUBTEST: live at hangcheck
> --
> 2.34.1
>
More information about the igt-dev
mailing list