[PATCH i-g-t v4 02/25] tests/intel: Introduce Memory management subcategory

Wed Mar 20 02:34:41 UTC 2024

LGTM
Reviewed-by: Priyanka Dandamudi <Priyanka.dandamudi at intel.com>

> -----Original Message-----
> From: Piecielska, Katarzyna <katarzyna.piecielska at intel.com>
> Sent: Tuesday, March 19, 2024 4:37 PM
> To: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: Wilson, Chris P <chris.p.wilson at intel.com>; Kamil Konieczny
> <kamil.konieczny at linux.intel.com>; Mauro Carvalho Chehab
> <mauro.chehab at linux.intel.com>
> Subject: RE: [PATCH i-g-t v4 02/25] tests/intel: Introduce Memory
> management subcategory
> 
> >   * TEST: gem set tiling vs gtt
> >   * Description: Check set_tiling vs gtt mmap coherency.
> >   * Feature: gtt
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiling vs gtt coherency
> >   * Run type: FULL
> 
> For some tests, there is a Test category and for some it is not present is that
> expected?
> For Example, see above it doesn't have the Test category. Can you please look
> into it?
> --Priyanka
> [ Katarzyna] Test category is not a mandatory field for documentation.
> Currently I am not updating that. We can look at this field later.
> Kasia
> 
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_set_tiling_vs_pwrite.c
> > b/tests/intel/gem_set_tiling_vs_pwrite.c
> > index ede0c58b6..a358ddba6 100644
> > --- a/tests/intel/gem_set_tiling_vs_pwrite.c
> > +++ b/tests/intel/gem_set_tiling_vs_pwrite.c
> > @@ -42,6 +42,9 @@
> >   * TEST: gem set tiling vs pwrite
> >   * Description: Check set_tiling vs pwrite coherency.
> >   * Feature: gtt
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiling vs pwrite coherency
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_streaming_writes.c
> > b/tests/intel/gem_streaming_writes.c
> > index fc2d3d89f..dd2f28331 100644
> > --- a/tests/intel/gem_streaming_writes.c
> > +++ b/tests/intel/gem_streaming_writes.c
> > @@ -43,6 +43,9 @@
> >  /**
> >   * TEST: gem streaming writes
> >   * Description: Test of streaming writes into active GPU sources
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: barrier
> >   * Run type: FULL
> >   *
> >   * SUBTEST: batch-cpu
> > diff --git a/tests/intel/gem_tiled_blits.c
> > b/tests/intel/gem_tiled_blits.c index
> > 27971a2b9..ec6e88477 100644
> > --- a/tests/intel/gem_tiled_blits.c
> > +++ b/tests/intel/gem_tiled_blits.c
> > @@ -58,6 +58,9 @@
> >   * TEST: gem tiled blits
> >   * Description: Test doing many tiled blits, with a working set
> > larger than the aperture size.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiled blits
> >   * Run type: FULL
> >   *
> >   * SUBTEST: basic
> > diff --git a/tests/intel/gem_tiled_fence_blits.c
> > b/tests/intel/gem_tiled_fence_blits.c
> > index c536c3699..920eeb42d 100644
> > --- a/tests/intel/gem_tiled_fence_blits.c
> > +++ b/tests/intel/gem_tiled_fence_blits.c
> > @@ -51,6 +51,9 @@
> >   *   Tests fence management problems related to tiled blits by performing
> > many blits on tiled
> >   *   buffer objects with fences enabled and with working set larger than the
> > aperture size.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiled blits
> >   *
> >   * SUBTEST: basic
> >   * Description: Check basic functionality.
> > diff --git a/tests/intel/gem_tiled_partial_pwrite_pread.c
> > b/tests/intel/gem_tiled_partial_pwrite_pread.c
> > index d4f66d51e..c4686739e 100644
> > --- a/tests/intel/gem_tiled_partial_pwrite_pread.c
> > +++ b/tests/intel/gem_tiled_partial_pwrite_pread.c
> > @@ -42,6 +42,9 @@
> >   * TEST: gem tiled partial pwrite pread
> >   * Description: Test pwrite/pread consistency when touching partial
> > cachelines.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiled pread/pwrite
> >   * Run type: FULL
> >   *
> >   * SUBTEST: reads
> > diff --git a/tests/intel/gem_tiled_pread_basic.c
> > b/tests/intel/gem_tiled_pread_basic.c
> > index a2253b51e..13181d86c 100644
> > --- a/tests/intel/gem_tiled_pread_basic.c
> > +++ b/tests/intel/gem_tiled_pread_basic.c
> > @@ -52,6 +52,9 @@
> >   * TEST: gem tiled pread basic
> >   * Description: Test pread behavior on tiled objects with respect to
> > the reported swizzling value.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiled pread/pwrite
> >   * Run type: BAT
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_tiled_pread_pwrite.c
> > b/tests/intel/gem_tiled_pread_pwrite.c
> > index 2f0f6f547..f8bc79731 100644
> > --- a/tests/intel/gem_tiled_pread_pwrite.c
> > +++ b/tests/intel/gem_tiled_pread_pwrite.c
> > @@ -62,6 +62,9 @@
> >   * TEST: gem tiled pread pwrite
> >   * Description: Test swizzling by testing pwrite does the inverse of pread.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiled pread/pwrite
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_tiled_swapping.c
> > b/tests/intel/gem_tiled_swapping.c
> > index 90ce70bdb..13f9fb41f 100644
> > --- a/tests/intel/gem_tiled_swapping.c
> > +++ b/tests/intel/gem_tiled_swapping.c
> > @@ -62,6 +62,9 @@
> >   * TEST: gem tiled swapping
> >   * Description: Exercise swizzle code for swapping.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: swapping
> >   * Run type: FULL
> >   *
> >   * SUBTEST: non-threaded
> > diff --git a/tests/intel/gem_tiled_wb.c b/tests/intel/gem_tiled_wb.c
> > index 6a8b79ecc..ee17b587d 100644
> > --- a/tests/intel/gem_tiled_wb.c
> > +++ b/tests/intel/gem_tiled_wb.c
> > @@ -51,6 +51,9 @@
> >   *   This is a test of write-combining mmap's behavior on tiled objects with
> > respect to the reported
> >   *   swizzling value.
> >   * Feature: caching, gtt
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: cache
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_tiled_wc.c b/tests/intel/gem_tiled_wc.c
> > index
> > 1994453b3..356b48829 100644
> > --- a/tests/intel/gem_tiled_wc.c
> > +++ b/tests/intel/gem_tiled_wc.c
> > @@ -48,6 +48,9 @@
> >  /**
> >   * TEST: gem tiled wc
> >   * Feature: caching, gtt
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: cache
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_tiling_max_stride.c
> > b/tests/intel/gem_tiling_max_stride.c
> > index 5943ed93f..93b89b00e 100644
> > --- a/tests/intel/gem_tiling_max_stride.c
> > +++ b/tests/intel/gem_tiling_max_stride.c
> > @@ -43,6 +43,9 @@
> >   * TEST: gem tiling max stride
> >   * Description: Check that max fence stride works.
> >   * Feature: gtt, mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: fences
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/gem_unfence_active_buffers.c
> > b/tests/intel/gem_unfence_active_buffers.c
> > index d3bc1cee6..aaa841f46 100644
> > --- a/tests/intel/gem_unfence_active_buffers.c
> > +++ b/tests/intel/gem_unfence_active_buffers.c
> > @@ -56,6 +56,9 @@
> >   * TEST: gem unfence active buffers
> >   * Description: Check for use-after-free in the fence stealing code.
> >   * Feature: synchronization
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: fences
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/i915_fb_tiling.c
> > b/tests/intel/i915_fb_tiling.c index
> > 14c17b030..e1dc54cc5 100644
> > --- a/tests/intel/i915_fb_tiling.c
> > +++ b/tests/intel/i915_fb_tiling.c
> > @@ -27,6 +27,9 @@
> >   * TEST: i915 fb tiling
> >   * Description: Object tiling must be fixed after framebuffer creation.
> >   * Feature: mapping
> > + * Sub-category: Memory management
> > + * Category: Desktop client
> > + * Functionality: tiling
> >   * Run type: FULL
> >   *
> >   * SUBTEST:
> > diff --git a/tests/intel/prime_busy.c b/tests/intel/prime_busy.c index
> > 90d79864f..79f5922a9 100644
> > --- a/tests/intel/prime_busy.c
> > +++ b/tests/intel/prime_busy.c
> > @@ -33,7 +33,7 @@
> >   * Feature: prime
> >   * Functionality: buffer management
> >   * Run type: FULL
> > - * Sub-category: DRM
> > + * Sub-category: Memory management
> >   * Test category: GEM_Legacy
> >   *
> >   * SUBTEST: after
> > diff --git a/tests/intel/prime_mmap.c b/tests/intel/prime_mmap.c index
> > 25b2939e9..e0735496a 100644
> > --- a/tests/intel/prime_mmap.c
> > +++ b/tests/intel/prime_mmap.c
> > @@ -54,9 +54,9 @@
> >   * TEST: prime mmap
> >   * Category: Infrastructure
> >   * Feature: prime
> > - * Functionality: memory management
> > + * Functionality: prime mmap
> >   * Run type: FULL
> > - * Sub-category: DRM
> > + * Sub-category: Memory management
> >   * Test category: GEM_Legacy
> >   *
> >   * SUBTEST: test_aperture_limit
> > diff --git a/tests/intel/prime_mmap_coherency.c
> > b/tests/intel/prime_mmap_coherency.c
> > index 01eb2002d..61bc5d312 100644
> > --- a/tests/intel/prime_mmap_coherency.c
> > +++ b/tests/intel/prime_mmap_coherency.c
> > @@ -38,9 +38,9 @@
> >   *   Test dma-buf mmap on !llc platforms mostly and provoke coherency
> bugs
> > so we know for sure where
> >   *   we need the sync ioctls.
> >   * Feature: prime
> > - * Functionality: memory management
> > + * Functionality: prime mmap
> >   * Run type: FULL
> > - * Sub-category: DRM
> > + * Sub-category: Memory management
> >   * Test category: GEM_Legacy
> >   *
> >   * SUBTEST: ioctl-errors
> > diff --git a/tests/intel/prime_self_import.c
> > b/tests/intel/prime_self_import.c index 2dbf4e20f..e1dcebfd8 100644
> > --- a/tests/intel/prime_self_import.c
> > +++ b/tests/intel/prime_self_import.c
> > @@ -51,32 +51,27 @@
> >   * Description: Check whether prime import/export works on the same
> > device... but with different fds.
> >   * Feature: prime
> >   * Functionality: buffer management
> > - * Sub-category: DRM
> > + * Sub-category: Memory management
> >   * Test category: GEM_Legacy
> > + * Run type: BAT
> >   *
> >   * SUBTEST: basic-llseek-bad
> >   * Description: Check dmabuf llseek support with invalid values.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: basic-llseek-size
> >   * Description: Check dmabuf llseek support.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: basic-with_fd_dup
> >   * Description: Check prime export with duplicate fd.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: basic-with_one_bo
> >   * Description: Check prime import/export with one buffer object.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: basic-with_one_bo_two_files
> >   * Description: Check prime/flink with one buffer object.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: basic-with_two_bos
> >   * Description: Check prime import/export with two buffer objects.
> > - * Run type: BAT
> >   *
> >   * SUBTEST: export-vs-gem_close-race
> >   * Description: Check race of gem close against prime export.
> > --
> > 2.34.1