[PATCH i-g-t v4 15/25] tests/intel: Introduce Power management subcategory

[Kamil Konieczny]

Hi Katarzyna,
On 2024-03-14 at 14:34:45 +0000, Katarzyna Piecielska wrote:
> Let's put e.g. pm_rps, pm_rpm, sseu, hwmon, suspend, freg multipliers
> and others under Power management subcategory.
> 
> v2: Make Sub-category/Functionality/Feature unique values. (Kamil)
> 
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> ---
>  tests/intel/gem_pxp.c               | 3 ++-
>  tests/intel/i915_pm_freq_mult.c     | 9 ++++++---
>  tests/intel/i915_pm_rc6_residency.c | 1 +
>  tests/intel/i915_pm_rpm.c           | 2 ++
>  tests/intel/i915_pm_rps.c           | 3 +++
>  tests/intel/i915_pm_sseu.c          | 3 +++
>  tests/intel/i915_power.c            | 3 +++
>  tests/intel/i915_suspend.c          | 3 +++
>  8 files changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/gem_pxp.c b/tests/intel/gem_pxp.c
> index 6a7f8e487..bef6056ba 100644
> --- a/tests/intel/gem_pxp.c
> +++ b/tests/intel/gem_pxp.c
> @@ -10,9 +10,10 @@
>  /**
>   * TEST: gem pxp
>   * Description: Test PXP that manages protected content through arbitrated HW-PXP-session
> - * Feature: PXP
> + * Feature: Protected Xe Path
------------------------ ^^
Is this correct? As I see this is as a hardware capability, not
driver. Maybe: cross-device? or device-to-device

>   * Functionality: pxp
>   * Sub-category: Power management
> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: create-protected-buffer
> diff --git a/tests/intel/i915_pm_freq_mult.c b/tests/intel/i915_pm_freq_mult.c
> index 49f6722b1..de65eaedf 100644
> --- a/tests/intel/i915_pm_freq_mult.c
> +++ b/tests/intel/i915_pm_freq_mult.c
> @@ -12,9 +12,12 @@
>  #include "igt_sysfs.h"
>  /**
>   * TEST: i915 pm freq mult
> - * Description:
> - *   Tests for sysfs controls (or multipliers) for IP blocks which run at frequencies different
> - *   from the main GT frequency.
> + * Description: Tests for sysfs controls (or multipliers) for IP blocks which
> + *		run at frequencies different from the main GT frequency.
> + * Category: Firmware

There are Sub-category conflicts with 'Firmware':

tests/intel/i915_pm_freq_mult.c: * Category: Firmware
tests/intel/xe_huc_copy.c: * Category: Firmware building block

tests/intel/gem_huc_copy.c: * Sub-category: Firmware
tests/intel/i915_selftest.c: * Sub-category: Firmware

> + * Functionality: freg multipliers
------------------------^
This is here lowercase 'G', should be 'q' - lowercase 'Q', so
s/freg/freq/

> + * Test category: i915
-------------------- ^^^^
imho drop this line.

> + * Sub-category: Power management
>   * Run type: FULL
>   *
>   * SUBTEST: media-freq
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index 30f57858d..67ae1f1f9 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -46,6 +46,7 @@
>   * Feature: GuCRC, pm_rc6
>   * Functionality: rc6
>   * Sub-category: Power management
> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: media-rc6-accuracy
> diff --git a/tests/intel/i915_pm_rpm.c b/tests/intel/i915_pm_rpm.c
> index 9fbfac744..be8d5fd77 100644
> --- a/tests/intel/i915_pm_rpm.c
> +++ b/tests/intel/i915_pm_rpm.c
> @@ -44,6 +44,8 @@
>   * TEST: i915 pm rpm
>   * Feature: pm_rpm
>   * Functionality: D3 state entry-exit
> + * Sub-category: Power management
> + * Category: Desktop client
>   * Test category: pm_rpm
>   * Run type: FULL
>   *
> diff --git a/tests/intel/i915_pm_rps.c b/tests/intel/i915_pm_rps.c
> index 820edd45e..3225ca25b 100644
> --- a/tests/intel/i915_pm_rps.c
> +++ b/tests/intel/i915_pm_rps.c
> @@ -49,6 +49,9 @@
>   * Description: Render P-States tests - verify GPU frequency changes
>   * Feature: pm_rps
>   * Test category: pm_rps
> + * Functionality: rps
> + * Sub-category: Power management
> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: basic-api
> diff --git a/tests/intel/i915_pm_sseu.c b/tests/intel/i915_pm_sseu.c
> index cee29a7c5..354403ef2 100644
> --- a/tests/intel/i915_pm_sseu.c
> +++ b/tests/intel/i915_pm_sseu.c
> @@ -39,6 +39,9 @@
>   * TEST: i915 pm sseu
>   * Description: Tests slice/subslice/EU power gating functionality.
>   * Feature: pm_sseu
> + * Sub-category: Power management
> + * Category: Desktop client
> + * Functionality: sseu
>   * Run type: FULL
>   *
>   * SUBTEST: full-enable
> diff --git a/tests/intel/i915_power.c b/tests/intel/i915_power.c
> index ee00cbcd8..0f083b375 100644
> --- a/tests/intel/i915_power.c
> +++ b/tests/intel/i915_power.c
> @@ -13,6 +13,9 @@
>   * Feature: hwmon
>   * Run type: FULL
>   * Test category: GEM_Legacy
> + * Sub-category: Power management
> + * Category: Desktop client
> + * Functionality: hwmon
>   *
>   * SUBTEST: sanity
>   * Description: Sanity check gpu power measurement
> diff --git a/tests/intel/i915_suspend.c b/tests/intel/i915_suspend.c
> index 4ee815031..7c96e25f5 100644
> --- a/tests/intel/i915_suspend.c
> +++ b/tests/intel/i915_suspend.c
> @@ -49,6 +49,9 @@
>   * Feature: suspend
>   * Functionality: s2idle w/o i915
>   * Test category: suspend
-------------------- ^^^^^^^
Do we need 'Test category'? If yes, maybe something other to
write in this field? It can potentialy collide.

Regards,
Kamil

> + * Functionality: suspend
> + * Sub-category: Power management
> + * Category: Desktop client
>   * Run type: FULL
>   *
>   * SUBTEST: basic-s2idle-without-i915
> -- 
> 2.34.1
>