[PATCH 3/3] tests/amdgpu/amd_dp_dsc: Check connector's dsc capability

Wu, Hersen hersenxs.wu at amd.com
Mon Mar 25 11:30:15 UTC 2024


[AMD Official Use Only - General]

Reviewed-by: Hersen Wu <Hersenxs.Wu at amd.com>

-----Original Message-----
From: Hung, Alex <Alex.Hung at amd.com>
Sent: Thursday, March 21, 2024 6:48 PM
To: igt-dev at lists.freedesktop.org
Cc: Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>; Wentland, Harry <Harry.Wentland at amd.com>; Wu, Hersen <hersenxs.wu at amd.com>; Hung, Alex <Alex.Hung at amd.com>
Subject: [PATCH 3/3] tests/amdgpu/amd_dp_dsc: Check connector's dsc capability

test_init() only sets data->mode when an output is DSC capable. As a result, it is necessary to check it before running each subtest.

Signed-off-by: Alex Hung <alex.hung at amd.com>
---
 tests/amdgpu/amd_dp_dsc.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/tests/amdgpu/amd_dp_dsc.c b/tests/amdgpu/amd_dp_dsc.c index f2da98259..64f1565f4 100644
--- a/tests/amdgpu/amd_dp_dsc.c
+++ b/tests/amdgpu/amd_dp_dsc.c
@@ -93,6 +93,15 @@ static void test_init(data_t *data)
        igt_display_reset(display);
 }

+static bool is_dsc_capable(drmModeModeInfo *mode) {
+       /* mode is not set in test_init() if it is dsc capable */
+       if (mode->hdisplay == 0 || mode->vdisplay == 0)
+               return false;
+
+       return true;
+}
+
 static void test_dsc_enable(data_t *data)  {
        bool dsc_on, dsc_after, dsc_before;
@@ -107,7 +116,7 @@ static void test_dsc_enable(data_t *data)
        for_each_pipe(&data->display, i) {
                /* Setup the output */
                output = data->output[i];
-               if (!output || !igt_output_is_connected(output))
+               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                        continue;

                igt_create_pattern_fb(data->fd,
@@ -245,7 +254,7 @@ static void test_dsc_slice_dimensions_change(data_t *data)
        for_each_pipe(&data->display, i) {
                /* Setup the output */
                output = data->output[i];
-               if (!output || !igt_output_is_connected(output))
+               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                        continue;

                igt_create_pattern_fb(data->fd,
@@ -335,7 +344,7 @@ static void test_dsc_link_settings(data_t *data)
        /* Setup all outputs */
        for_each_pipe(&data->display, i) {
                output = data->output[i];
-               if (!output || !igt_output_is_connected(output))
+               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                        continue;

                igt_create_pattern_fb(data->fd,
@@ -352,7 +361,7 @@ static void test_dsc_link_settings(data_t *data)
        /* Collect reference CRCs */
        for_each_pipe(&data->display, i) {
                output = data->output[i];
-               if (!output || !igt_output_is_connected(output))
+               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                        continue;

                igt_pipe_crc_collect_crc(data->pipe_crc[i], &ref_crc[i]); @@ -363,7 +372,7 @@ static void test_dsc_link_settings(data_t *data)
                        /* Write new link_settings */
                        for_each_pipe(&data->display, i) {
                                output = data->output[i];
-                               if (!output || !igt_output_is_connected(output))
+                               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                                        continue;

                                /* Write lower link settings */
@@ -380,7 +389,7 @@ static void test_dsc_link_settings(data_t *data)

                        for_each_pipe(&data->display, i) {
                                output = data->output[i];
-                               if (!output || !igt_output_is_connected(output))
+                               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                                        continue;

                                /* Verify lower link settings */
@@ -404,8 +413,9 @@ static void test_dsc_link_settings(data_t *data)
        /* Cleanup all fbs */
        for_each_pipe(&data->display, i) {
                output = data->output[i];
-               if (!output || !igt_output_is_connected(output))
+               if (!output || !igt_output_is_connected(output) ||
+!is_dsc_capable(&data->mode[i]))
                        continue;
+
                igt_remove_fb(data->fd, &ref_fb[i]);
        }

--
2.34.1



More information about the igt-dev mailing list