[PATCH i-g-t 12/12] tests/intel: Move xe_exec_reset.c to Reset Sub-category
Piecielska, Katarzyna
katarzyna.piecielska at intel.com
Tue Mar 26 09:23:11 UTC 2024
Hi Katarzyna,
On 2024-03-22 at 12:41:08 +0000, Katarzyna Piecielska wrote:
> It looks like Sub-category=Reset and Functionality=gt reset is better
> for xe_exec_reset.c test.
>
> Signed-off-by: Katarzyna Piecielska <katarzyna.piecielska at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Mauro Carvalho Chehab <mauro.chehab at linux.intel.com>
> Cc: Aditya Chauhan <aditya.chauhan at intel.com>
> Cc: Girotra Himanshu <himanshu.girotra at intel.com>
> ---
> tests/intel/xe_exec_reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> index 22735688a..cc10900d9 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -6,8 +6,8 @@
> /**
> * TEST: Basic tests for execbuf functionality for virtual and parallel exec_queues
> * Category: Hardware building block
> - * Sub-category: CMD submission
> - * Functionality: reset
> + * Sub-category: Reset
> + * Functionality: gt reset
> * Test category: functionality test
> */
>
There are still some problems left:
n.Functionality:../tests/device_reset.c: * Functionality: reset
n.Functionality:../tests/device_reset.c: * Functionality: sysfs reset
Looks inconsitent.
[Katarzyna] Fixed that ^^
n.Functionality:../tests/intel/gem_eio.c: * Functionality: reset
n.Functionality:../tests/intel/gem_reset_stats.c: * Functionality: reset
[Katarzyna] Sub-category=uapi, Functionality=reset is not a conflict, but 'sysfs reset' seems better.
n.Functionality:../tests/intel/i915_selftest.c: * Functionality: engine/GT reset
[Katarzyna] seems correct
n.Functionality:../tests/intel/xe_exec_reset.c: * Functionality: gt reset
[Katarzyna] seems correct
Thank You for your feedback.
Kasia
It can be left to future patch,
Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> --
> 2.34.1
>
More information about the igt-dev
mailing list